Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2300)

Unified Diff: appengine/findit/model/test/base_triaged_model_test.py

Issue 2416303002: [Findit] Adding support for triaging suspected builds from flake analysis (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/test/base_triaged_model_test.py
diff --git a/appengine/findit/model/test/base_triaged_model_test.py b/appengine/findit/model/test/base_triaged_model_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..1eed5a9f128f6bf6d0d146122155effc4e30dceb
--- /dev/null
+++ b/appengine/findit/model/test/base_triaged_model_test.py
@@ -0,0 +1,50 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+
+from model.base_triaged_model import TriagedModel
+from model.base_triaged_model import TriageResult
+
+
+class _DummyModel(TriagedModel):
+ completed = True
+
+
+class TriagedModelTest(unittest.TestCase):
+
+ def testUpdateTriageResult(self):
+ triage_result = 1
+ suspect_info = 'abcd'
+ user_name = 'test'
+
+ model = _DummyModel()
+ model.UpdateTriageResult(1, suspect_info, user_name)
+ self.assertEqual(len(model.triage_history), 1)
+ self.assertEqual(model.triage_history[0].triage_result, triage_result)
+ self.assertEqual(model.triage_history[0].suspect_info, suspect_info)
+ self.assertEqual(model.triage_history[0].user_name, user_name)
+
+ def testGetTriageHistory(self):
+ suspect_info = {
+ 'build_number': 123
+ }
+ user_name = 'test'
+
+ model = _DummyModel()
+ result = TriageResult()
+ result.triage_result = 1
+ result.user_name = user_name
+ result.suspect_info = suspect_info
+ model.triage_history.append(result)
+
+ triage_history = TriagedModel.GetTriageHistory(model)
+
+ # Because TriageResult's triage_time uses auto_now=True, a direct dict
+ # comparison will always fail. Instead compare each relevant field
+ # individually.
+ self.assertEqual(len(triage_history), 1)
+ self.assertEqual(triage_history[0].get('user_name'), user_name)
+ self.assertEqual(triage_history[0].get('triage_result'), 'Incorrect')
+ self.assertEqual(triage_history[0].get('suspect_info'), suspect_info)
« no previous file with comments | « appengine/findit/model/flake/master_flake_analysis.py ('k') | appengine/findit/templates/build_failure.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698