appengine/findit/handlers/build_failure.py - Issue 2416303002: [Findit] Adding support for triaging suspected builds from flake analysis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/build_failure.py

Issue 2416303002: [Findit] Adding support for triaging suspected builds from flake analysis (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/handlers/build_failure.py

diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py

index 77bd7543a5888fcbaacc7a25f0438334abd7cb6c..4896e94656ebe388cd059266ec9015256f971d29 100644

--- a/appengine/findit/handlers/build_failure.py

+++ b/appengine/findit/handlers/build_failure.py

@@ -397,12 +397,6 @@ def _GetAllSuspectedCLsAndCheckStatus(

class BuildFailure(BaseHandler):

PERMISSION_LEVEL = Permission.ANYONE

- def _ShowDebugInfo(self):

- # Show debug info only if the app is run locally during development, if the

- # currently logged-in user is an admin, or if it is explicitly requested

- # with parameter 'debug=1'.

- return users.is_current_user_admin() or self.request.get('debug') == '1'

def _ShowTriageHelpButton(self):

return users.is_current_user_admin()