Chromium Code Reviews Chromium Code Reviews
Issue 2416303002:
[Findit] Adding support for triaging suspected builds from flake analysis (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <head> | 2 <head> |
| 3 <title>{% block title %}{% endblock %} Failure</title> | 3 <title>{% block title %}{% endblock %} Failure</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="/common.css"> | 5 <link rel="stylesheet" href="/common.css"> |
| 6 <style> | 6 <style> |
| 7 .running { | 7 .running { |
| 8 color: #666666; | 8 color: #666666; |
| 9 background-color: #fffc6c; | 9 background-color: #fffc6c; |
| 10 border-color: #c5c56d; | 10 border-color: #c5c56d; |
| (...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 245 <table> | 245 <table> |
| 246 <tr><th>CL</th><th>Confidence</th><th>Feedback</th></tr> | 246 <tr><th>CL</th><th>Confidence</th><th>Feedback</th></tr> |
| 247 {% for suspected_cl in suspected_cls %} | 247 {% for suspected_cl in suspected_cls %} |
| 248 <tr> | 248 <tr> |
| 249 <td>{{ suspected_cl.repo_name }} <a href="{{ suspected_cl.url }}">{{ suspected_cl.commit_position or suspected_cl.revision }}</a></td> | 249 <td>{{ suspected_cl.repo_name }} <a href="{{ suspected_cl.url }}">{{ suspected_cl.commit_position or suspected_cl.revision }}</a></td> |
| 250 <td>{{ suspected_cl.confidence }}</td> | 250 <td>{{ suspected_cl.confidence }}</td> |
| 251 <td> | 251 <td> |
| 252 {% set cl_info = suspected_cl.repo_name + '/' + suspected_cl.rev ision %} | 252 {% set cl_info = suspected_cl.repo_name + '/' + suspected_cl.rev ision %} |
| 253 {% if suspected_cl.status == 0 %} | 253 {% if suspected_cl.status == 0 %} |
| 254 <input type="radio" name="{{ cl_info }}" value="0" checked=" checked" onchange="triageSuspectedCL(this)">Correct | 254 <input type="radio" name="{{ cl_info }}" value="0" checked=" checked" onchange="triageSuspectedCL(this)">Correct |
| 255 <input type="radio" name="{{ cl_info }}" value="1" onchange= "triageSuspectedCL(this)">Inorrect | 255 <input type="radio" name="{{ cl_info }}" value="1" onchange= "triageSuspectedCL(this)">Incorrect |
|
chanli
2016/10/15 01:47:21
Thank you for this fix..
| |
| 256 {% elif suspected_cl.status == 1 %} | 256 {% elif suspected_cl.status == 1 %} |
| 257 <input type="radio" name="{{ cl_info }}" value="0" onchange= "triageSuspectedCL(this)">Correct | 257 <input type="radio" name="{{ cl_info }}" value="0" onchange= "triageSuspectedCL(this)">Correct |
| 258 <input type="radio" name="{{ cl_info }}" value="1" checked=" checked" onchange="triageSuspectedCL(this)">Inorrect | 258 <input type="radio" name="{{ cl_info }}" value="1" checked=" checked" onchange="triageSuspectedCL(this)">Incorrect |
| 259 {% else %} | 259 {% else %} |
| 260 <input type="radio" name="{{ cl_info }}" value="0" onchange= "triageSuspectedCL(this)">Correct | 260 <input type="radio" name="{{ cl_info }}" value="0" onchange= "triageSuspectedCL(this)">Correct |
| 261 <input type="radio" name="{{ cl_info }}" value="1" onchange= "triageSuspectedCL(this)">Inorrect | 261 <input type="radio" name="{{ cl_info }}" value="1" onchange= "triageSuspectedCL(this)">Incorrect |
| 262 {% endif %} | 262 {% endif %} |
| 263 </td> | 263 </td> |
| 264 </tr> | 264 </tr> |
| 265 {% endfor %} | 265 {% endfor %} |
| 266 </table> | 266 </table> |
| 267 {% endif %} | 267 {% endif %} |
| 268 <div id="cl_result_triaged"></div> | 268 <div id="cl_result_triaged"></div> |
| 269 </div> | 269 </div> |
| 270 {% if show_debug_info %} | 270 {% if show_debug_info %} |
| 271 <div id="duplicates_marked"></div> | 271 <div id="duplicates_marked"></div> |
| (...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 315 appearing in the failure log. (eg: file.h was changed and | 315 appearing in the failure log. (eg: file.h was changed and |
| 316 file_unittest.cc or file_impl.cc appeared in the log.)</li> | 316 file_unittest.cc or file_impl.cc appeared in the log.)</li> |
| 317 <li>1: The CL rolled a dependency within src/DEPS and a file of that | 317 <li>1: The CL rolled a dependency within src/DEPS and a file of that |
| 318 dependency appears in the failure log. (eg: third_party/dep | 318 dependency appears in the failure log. (eg: third_party/dep |
| 319 was changed in src/DEPS and third_party/dep/f.cpp appeared | 319 was changed in src/DEPS and third_party/dep/f.cpp appeared |
| 320 in the log.)</li> | 320 in the log.)</li> |
| 321 </ul> | 321 </ul> |
| 322 (More rules will be added when implemented.) | 322 (More rules will be added when implemented.) |
| 323 </div> | 323 </div> |
| 324 </body> | 324 </body> |
| OLD | NEW |
