[Findit] Adding support for triaging suspected builds from flake analysis

appengine/findit/common/base_handler.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import json
 import logging
 
 from google.appengine.api import users
 import jinja2
@@ skipping 40 matching lines @@
     elif self.PERMISSION_LEVEL == Permission.ADMIN:
       return auth_util.IsCurrentUserAdmin()
     else:
       logging.error('Unknown permission level: %s' % self.PERMISSION_LEVEL)
       return False
 
   def IsCorpUserOrAdmin(self):
     """Returns True if the user logged in with corp account or as admin."""
     user_email = auth_util.GetUserEmail()
     return ((user_email and user_email.endswith('@google.com')) or
-        auth_util.IsCurrentUserAdmin())
+            auth_util.IsCurrentUserAdmin())
+
+  def _ShowDebugInfo(self):  # pragma: no cover

[chanli, 2016/10/15 01:47:21]

Do you mind adding a test for this function? Although it should be straight
forward...

[lijeffrey, 2016/10/15 02:16:41]

Done.

+    # Show debug info only if the app is run locally during development, if the
+    # currently logged-in user is an admin, or if it is explicitly requested
+    # with parameter 'debug=1'.
+    return users.is_current_user_admin() or self.request.get('debug') == '1'
 
   @staticmethod
   def CreateError(error_message, return_code=500):
     logging.error('Error occurred: %s', error_message)
     return {
         'template': 'error.html',
         'data': {'error_message': error_message},
         'return_code': return_code,
     }
 
@@ skipping 107 matching lines @@
       return_code = 500
       cache_expiry = None
 
     self._SendResponse(template, data, return_code, cache_expiry)
 
   def get(self):
     self._Handle(self.HandleGet)
 
   def post(self):
     self._Handle(self.HandlePost)