Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc

Issue 2416253004: ash: Use session_manager::SessionState (Closed)
Patch Set: add comment about session state in SessionStaetDelegateChromeos Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/session/session_state_delegate.h" 5 #include "ash/common/session/session_state_delegate.h"
6 #include "ash/common/wm_shell.h" 6 #include "ash/common/wm_shell.h"
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/chromeos/login/lock/screen_locker.h" 9 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
10 #include "chrome/browser/chromeos/login/lock/screen_locker_tester.h" 10 #include "chrome/browser/chromeos/login/lock/screen_locker_tester.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, PRE_CancelAdding) { 104 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, PRE_CancelAdding) {
105 RegisterUser(kTestUsers[0]); 105 RegisterUser(kTestUsers[0]);
106 RegisterUser(kTestUsers[1]); 106 RegisterUser(kTestUsers[1]);
107 RegisterUser(kTestUsers[2]); 107 RegisterUser(kTestUsers[2]);
108 StartupUtils::MarkOobeCompleted(); 108 StartupUtils::MarkOobeCompleted();
109 } 109 }
110 110
111 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, CancelAdding) { 111 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, CancelAdding) {
112 EXPECT_EQ(3u, user_manager::UserManager::Get()->GetUsers().size()); 112 EXPECT_EQ(3u, user_manager::UserManager::Get()->GetUsers().size());
113 EXPECT_EQ(0u, user_manager::UserManager::Get()->GetLoggedInUsers().size()); 113 EXPECT_EQ(0u, user_manager::UserManager::Get()->GetLoggedInUsers().size());
114 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY, 114 EXPECT_EQ(session_manager::SessionState::LOGIN_PRIMARY,
115 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState()); 115 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState());
116 116
117 LoginUser(kTestUsers[0]); 117 LoginUser(kTestUsers[0]);
118 EXPECT_EQ(1u, user_manager::UserManager::Get()->GetLoggedInUsers().size()); 118 EXPECT_EQ(1u, user_manager::UserManager::Get()->GetLoggedInUsers().size());
119 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 119 EXPECT_EQ(session_manager::SessionState::ACTIVE,
120 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState()); 120 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState());
121 121
122 UserAddingScreen::Get()->Start(); 122 UserAddingScreen::Get()->Start();
123 content::RunAllPendingInMessageLoop(); 123 content::RunAllPendingInMessageLoop();
124 EXPECT_EQ(1, user_adding_started()); 124 EXPECT_EQ(1, user_adding_started());
125 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_SECONDARY, 125 EXPECT_EQ(session_manager::SessionState::LOGIN_SECONDARY,
126 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState()); 126 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState());
127 127
128 UserAddingScreen::Get()->Cancel(); 128 UserAddingScreen::Get()->Cancel();
129 WaitUntilUserAddingFinishedOrCancelled(); 129 WaitUntilUserAddingFinishedOrCancelled();
130 content::RunAllPendingInMessageLoop(); 130 content::RunAllPendingInMessageLoop();
131 EXPECT_EQ(1, user_adding_finished()); 131 EXPECT_EQ(1, user_adding_finished());
132 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 132 EXPECT_EQ(session_manager::SessionState::ACTIVE,
133 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState()); 133 ash::WmShell::Get()->GetSessionStateDelegate()->GetSessionState());
134 134
135 EXPECT_TRUE(LoginDisplayHost::default_host() == nullptr); 135 EXPECT_TRUE(LoginDisplayHost::default_host() == nullptr);
136 EXPECT_EQ(1u, user_manager::UserManager::Get()->GetLoggedInUsers().size()); 136 EXPECT_EQ(1u, user_manager::UserManager::Get()->GetLoggedInUsers().size());
137 EXPECT_EQ(kTestUsers[0], 137 EXPECT_EQ(kTestUsers[0],
138 user_manager::UserManager::Get()->GetActiveUser()->email()); 138 user_manager::UserManager::Get()->GetActiveUser()->email());
139 } 139 }
140 140
141 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, PRE_AddingSeveralUsers) { 141 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, PRE_AddingSeveralUsers) {
142 RegisterUser(kTestUsers[0]); 142 RegisterUser(kTestUsers[0]);
143 RegisterUser(kTestUsers[1]); 143 RegisterUser(kTestUsers[1]);
144 RegisterUser(kTestUsers[2]); 144 RegisterUser(kTestUsers[2]);
145 StartupUtils::MarkOobeCompleted(); 145 StartupUtils::MarkOobeCompleted();
146 } 146 }
147 147
148 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, AddingSeveralUsers) { 148 IN_PROC_BROWSER_TEST_F(UserAddingScreenTest, AddingSeveralUsers) {
149 ash::WmShell* wm_shell = ash::WmShell::Get(); 149 ash::WmShell* wm_shell = ash::WmShell::Get();
150 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_PRIMARY, 150 EXPECT_EQ(session_manager::SessionState::LOGIN_PRIMARY,
151 wm_shell->GetSessionStateDelegate()->GetSessionState()); 151 wm_shell->GetSessionStateDelegate()->GetSessionState());
152 LoginUser(kTestUsers[0]); 152 LoginUser(kTestUsers[0]);
153 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 153 EXPECT_EQ(session_manager::SessionState::ACTIVE,
154 wm_shell->GetSessionStateDelegate()->GetSessionState()); 154 wm_shell->GetSessionStateDelegate()->GetSessionState());
155 155
156 user_manager::UserManager* user_manager = user_manager::UserManager::Get(); 156 user_manager::UserManager* user_manager = user_manager::UserManager::Get();
157 157
158 for (int i = 1; i < 3; ++i) { 158 for (int i = 1; i < 3; ++i) {
159 UserAddingScreen::Get()->Start(); 159 UserAddingScreen::Get()->Start();
160 content::RunAllPendingInMessageLoop(); 160 content::RunAllPendingInMessageLoop();
161 EXPECT_EQ(i, user_adding_started()); 161 EXPECT_EQ(i, user_adding_started());
162 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_LOGIN_SECONDARY, 162 EXPECT_EQ(session_manager::SessionState::LOGIN_SECONDARY,
163 wm_shell->GetSessionStateDelegate()->GetSessionState()); 163 wm_shell->GetSessionStateDelegate()->GetSessionState());
164 AddUser(kTestUsers[i]); 164 AddUser(kTestUsers[i]);
165 WaitUntilUserAddingFinishedOrCancelled(); 165 WaitUntilUserAddingFinishedOrCancelled();
166 content::RunAllPendingInMessageLoop(); 166 content::RunAllPendingInMessageLoop();
167 EXPECT_EQ(i, user_adding_finished()); 167 EXPECT_EQ(i, user_adding_finished());
168 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 168 EXPECT_EQ(session_manager::SessionState::ACTIVE,
169 wm_shell->GetSessionStateDelegate()->GetSessionState()); 169 wm_shell->GetSessionStateDelegate()->GetSessionState());
170 EXPECT_TRUE(LoginDisplayHost::default_host() == nullptr); 170 EXPECT_TRUE(LoginDisplayHost::default_host() == nullptr);
171 ASSERT_EQ(unsigned(i + 1), user_manager->GetLoggedInUsers().size()); 171 ASSERT_EQ(unsigned(i + 1), user_manager->GetLoggedInUsers().size());
172 } 172 }
173 173
174 EXPECT_EQ(ash::SessionStateDelegate::SESSION_STATE_ACTIVE, 174 EXPECT_EQ(session_manager::SessionState::ACTIVE,
175 wm_shell->GetSessionStateDelegate()->GetSessionState()); 175 wm_shell->GetSessionStateDelegate()->GetSessionState());
176 176
177 // Now check how unlock policy works for these users. 177 // Now check how unlock policy works for these users.
178 PrefService* prefs1 = 178 PrefService* prefs1 =
179 ProfileHelper::Get() 179 ProfileHelper::Get()
180 ->GetProfileByUserUnsafe(user_manager->GetLoggedInUsers()[0]) 180 ->GetProfileByUserUnsafe(user_manager->GetLoggedInUsers()[0])
181 ->GetPrefs(); 181 ->GetPrefs();
182 PrefService* prefs2 = 182 PrefService* prefs2 =
183 ProfileHelper::Get() 183 ProfileHelper::Get()
184 ->GetProfileByUserUnsafe(user_manager->GetLoggedInUsers()[1]) 184 ->GetProfileByUserUnsafe(user_manager->GetLoggedInUsers()[1])
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 276
277 UserAddingScreen::Get()->Start(); 277 UserAddingScreen::Get()->Start();
278 content::RunAllPendingInMessageLoop(); 278 content::RunAllPendingInMessageLoop();
279 CheckScreenIsVisible(); 279 CheckScreenIsVisible();
280 UserAddingScreen::Get()->Cancel(); 280 UserAddingScreen::Get()->Cancel();
281 WaitUntilUserAddingFinishedOrCancelled(); 281 WaitUntilUserAddingFinishedOrCancelled();
282 content::RunAllPendingInMessageLoop(); 282 content::RunAllPendingInMessageLoop();
283 } 283 }
284 284
285 } // namespace chromeos 285 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/ui/user_adding_screen.cc ('k') | chrome/browser/ui/ash/session_state_delegate_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698