Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: test/unittests/BUILD.gn

Issue 2416243002: Make unittests work in component build (Closed)
Patch Set: updates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-result.h ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/BUILD.gn
diff --git a/test/unittests/BUILD.gn b/test/unittests/BUILD.gn
index 6671f417994dd16d8f1bc1200d0d777d3d984815..e31f33377c08d148797bd1001a48a230b4a83dc8 100644
--- a/test/unittests/BUILD.gn
+++ b/test/unittests/BUILD.gn
@@ -160,6 +160,7 @@ v8_executable("unittests") {
#}],
deps = [
+ "../..:v8",
"../..:v8_libbase",
"../..:v8_libplatform",
"//build/config/sanitizers:deps",
@@ -168,17 +169,6 @@ v8_executable("unittests") {
"//testing/gtest",
]
- defines = []
-
- if (is_component_build) {
- # compiler-unittests can't be built against a shared library, so we
- # need to depend on the underlying static target in that case.
- deps += [ "../..:v8_maybe_snapshot" ]
- defines += [ "BUILDING_V8_SHARED" ]
- } else {
- deps += [ "../..:v8" ]
- }
-
if (is_win) {
# This warning is benignly triggered by the U16 and U32 macros in
# bytecode-utils.h.
« no previous file with comments | « src/wasm/wasm-result.h ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698