Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2416233002: Faster 4f gradient premul path (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Faster 4f gradient premul path Similar to https://codereview.chromium.org/2409583003/, perform the premul in 4f. It turns out it's even faster to avoid the 255 load multiplication in this case. Also includes some template plumbing because DstTraits<>::load now needs to be premul-aware (previously it wasn't). R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416233002 Committed: https://skia.googlesource.com/skia/+/3a2e45a6ed50c07cb1a710d3f7b74be796e61251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M src/effects/gradients/Sk4fGradientBase.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/gradients/Sk4fGradientPriv.h View 2 chunks +15 lines, -16 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
before: 17/17 MB 1 880µs 914µs 898µs 920µs 2% ██▇▇▇▁▁▁▁▁ 8888 gradient_linear_mirror_3color_4f 17/17 MB 1 ...
4 years, 2 months ago (2016-10-14 14:36:43 UTC) #2
reed1
lgtm
4 years, 2 months ago (2016-10-14 14:58:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416233002/1
4 years, 2 months ago (2016-10-14 15:17:29 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 15:18:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a2e45a6ed50c07cb1a710d3f7b74be796e61251

Powered by Google App Engine
This is Rietveld 408576698