Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2416213002: Revert of [inspector] Record EvaluateScript trace event upon console evaluation (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
caseq, dgozman, alph, paulirish
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] Record EvaluateScript trace event upon console evaluation (patchset #2 id:20001 of https://codereview.chromium.org/2413943002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10647 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] Record EvaluateScript trace event upon console evaluation > > It will allow timeline to show JS profile on code evaluated from console. > > BUG=chromium:655430 > > Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 > Cr-Commit-Position: refs/heads/master@{#40289} TBR=caseq@chromium.org,paulirish@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655430 Committed: https://crrev.com/64378066b7f520e4b62dae472e4acba56469dd4c Cr-Commit-Position: refs/heads/master@{#40299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/inspector/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/v8-runtime-agent-impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [inspector] Record EvaluateScript trace event upon console evaluation
4 years, 2 months ago (2016-10-14 08:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416213002/1
4 years, 2 months ago (2016-10-14 08:51:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:51:26 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:51:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64378066b7f520e4b62dae472e4acba56469dd4c
Cr-Commit-Position: refs/heads/master@{#40299}

Powered by Google App Engine
This is Rietveld 408576698