media/base/stream_parser_unittest.cc - Issue 2416183002: media: Use native DemuxerStream enum types in media mojo interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/stream_parser_unittest.cc

Issue 2416183002: media: Use native DemuxerStream enum types in media mojo interfaces (Closed)

Patch Set: more fix and rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/stream_parser_unittest.cc

diff --git a/media/base/stream_parser_unittest.cc b/media/base/stream_parser_unittest.cc

index 21e3715d882a20b1efb40a511ef0da93fa3a9504..f3ae11358d3f8567a76b973c68e08453f63a6e95 100644

--- a/media/base/stream_parser_unittest.cc

+++ b/media/base/stream_parser_unittest.cc

@@ -49,8 +49,7 @@ static void GenerateBuffers(const int* decode_timestamps,

BufferQueue* queue) {

DCHECK(decode_timestamps);

DCHECK(queue);

- DCHECK_NE(type, DemuxerStream::UNKNOWN);

- DCHECK_LT(type, DemuxerStream::NUM_TYPES);

+ DCHECK_LT(type, DemuxerStream::UNKNOWN);

jrummell 2016/10/14 22:13:24 Should this not be TYPE_MAX? UNKNOWN is 0. Maybe k

xhwang 2016/10/15 05:13:22 Good catch. Done.

for (int i = 0; decode_timestamps[i] != kEnd; ++i) {

scoped_refptr<StreamParserBuffer> buffer =

StreamParserBuffer::CopyFrom(kFakeData, sizeof(kFakeData),

« no previous file with comments | « media/base/stream_parser_buffer.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »