media: Use native DemuxerStream enum types in media mojo interfaces

media: Use native DemuxerStream enum types in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57
Cr-Commit-Position: refs/heads/master@{#425551}

[xhwang, 2016-10-14 22:02:07]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org, jrummell@chromium.org

[xhwang, 2016-10-14 22:02:08]

Another one. PTAL

[jrummell, 2016-10-14 22:13:25]

lgtm w/nit.

https://codereview.chromium.org/2416183002/diff/20001/media/base/stream_parse...
File media/base/stream_parser_unittest.cc (right):

https://codereview.chromium.org/2416183002/diff/20001/media/base/stream_parse...
media/base/stream_parser_unittest.cc:52: DCHECK_LT(type,
DemuxerStream::UNKNOWN);
Should this not be TYPE_MAX? UNKNOWN is 0. Maybe keep the original test as well
(!= UNKNOWN)?

[dcheng, 2016-10-15 00:45:36]

mojo lgtm with other comments addressed

[xhwang, 2016-10-15 05:13:23]

https://codereview.chromium.org/2416183002/diff/20001/media/base/stream_parse...
File media/base/stream_parser_unittest.cc (right):

https://codereview.chromium.org/2416183002/diff/20001/media/base/stream_parse...
media/base/stream_parser_unittest.cc:52: DCHECK_LT(type,
DemuxerStream::UNKNOWN);
On 2016/10/14 22:13:24, jrummell wrote:
> Should this not be TYPE_MAX? UNKNOWN is 0. Maybe keep the original test as
well
> (!= UNKNOWN)?

Good catch. Done.

[xhwang, 2016-10-15 05:14:27]

comments addressed

[xhwang, 2016-10-15 05:14:44]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-10-15 05:14:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2416183002/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-10-15 05:14:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 06:45:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-15 06:47:02]

Description was changed from

==========
media: Use native DemuxerStream enum types in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native DemuxerStream enum types in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57
Cr-Commit-Position: refs/heads/master@{#425551}
==========

[commit-bot: I haz the power, 2016-10-15 06:47:03]

Patchset 3 (id:??) landed as
https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57
Cr-Commit-Position: refs/heads/master@{#425551}