Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(240)

Issue 2416173004: Fix breakpad 32-bit build. (Closed)

Created:
2 years, 11 months ago by bradnelson
Modified:
2 years, 11 months ago
Reviewers:
Derek Schuff, bradn
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M buildbot/buildbot_standard.py View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bradn
2 years, 11 months ago (2016-10-14 17:26:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416173004/20001
2 years, 11 months ago (2016-10-14 17:30:57 UTC) #4
Derek Schuff
https://codereview.chromium.org/2416173004/diff/1/buildbot/buildbot_standard.py File buildbot/buildbot_standard.py (right): https://codereview.chromium.org/2416173004/diff/1/buildbot/buildbot_standard.py#newcode403 buildbot/buildbot_standard.py:403: cc = 'CXX=../../third_party/llvm-build/Release+Asserts/bin/clang' Should this be CC=?
2 years, 11 months ago (2016-10-14 17:31:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416173004/20001
2 years, 11 months ago (2016-10-14 17:34:54 UTC) #9
bradn
https://codereview.chromium.org/2416173004/diff/1/buildbot/buildbot_standard.py File buildbot/buildbot_standard.py (right): https://codereview.chromium.org/2416173004/diff/1/buildbot/buildbot_standard.py#newcode403 buildbot/buildbot_standard.py:403: cc = 'CXX=../../third_party/llvm-build/Release+Asserts/bin/clang' On 2016/10/14 17:31:07, Derek Schuff wrote: ...
2 years, 11 months ago (2016-10-14 17:35:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416173004/20001
2 years, 11 months ago (2016-10-14 17:35:34 UTC) #13
commit-bot: I haz the power
2 years, 11 months ago (2016-10-14 17:36:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/c9a4a41cf...

Powered by Google App Engine
This is Rietveld 408576698