content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc - Issue 2416173003: Rename Event.Latency.* to Event.Latency.ScrollUpdate.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

Issue 2416173003: Rename Event.Latency.* to Event.Latency.ScrollUpdate.* (Closed)

Patch Set: Use of obsolete for histograms instead of deleting. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/render_widget_host_latency_tracker.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

index c3cc5878315a5976931f81bbb97b567846fab182..549945ece38c4f4b4d0cc1df595fa47e64701246 100644

--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

@@ -121,8 +121,10 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestWheelHistograms) {

EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.WheelUI", 1));

EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.WheelAcked", 1));

- EXPECT_TRUE(HistogramSizeEq(

- "Event.Latency.Wheel.TimeToFirstScrollUpdateSwapBegin2", 1));

+ EXPECT_TRUE(

+ HistogramSizeEq("Event.Latency.ScrollUpdate.Wheel."

+ "TimeToFirstScrollUpdateSwapBegin2",

+ 1));

EXPECT_TRUE(HistogramSizeEq(

"Event.Latency.ScrollUpdate.Wheel.TimeToHandled2_Main",

@@ -225,10 +227,11 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchHistograms) {

"Event.Latency.ScrollUpdate.BrowserNotifiedToBeforeGpuSwap", 1));

EXPECT_TRUE(HistogramSizeEq("Event.Latency.ScrollUpdate.GpuSwap", 1));

EXPECT_TRUE(HistogramSizeEq(

- "Event.Latency.Touch.TimeToFirstScrollUpdateSwapBegin2", 1));

+ "Event.Latency.ScrollUpdate.Touch.TimeToFirstScrollUpdateSwapBegin2",

+ 1));

EXPECT_TRUE(HistogramSizeEq(

- "Event.Latency.Touch.TimeToScrollUpdateSwapBegin2", 0));

+ "Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin2", 0));

EXPECT_TRUE(HistogramSizeEq(

"Event.Latency.ScrollUpdate.Touch.TimeToHandled2_Main",