Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2416173003: Rename Event.Latency.* to Event.Latency.ScrollUpdate.* (Closed)

Created:
4 years, 2 months ago by sahel
Modified:
4 years, 2 months ago
Reviewers:
tdresser, Steven Holte
CC:
chromium-reviews, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Event.Latency.* to Event.Latency.ScrollUpdate.* BUG=622827 Committed: https://crrev.com/956857461fdc0f0d2beb304bbc96ffda398d9c37 Cr-Commit-Position: refs/heads/master@{#425452}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use of obsolete for histograms instead of deleting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 8 chunks +50 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
sahel
4 years, 2 months ago (2016-10-14 17:30:39 UTC) #6
Steven Holte
lgtm https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml#oldcode13987 tools/metrics/histograms/histograms.xml:13987: -<histogram name="Event.Latency.Touch.TimeToFirstScrollUpdateSwapBegin2" Mark obsolete instead of removing?
4 years, 2 months ago (2016-10-14 18:02:49 UTC) #7
tdresser
LGTM, thanks! https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml#oldcode13987 tools/metrics/histograms/histograms.xml:13987: -<histogram name="Event.Latency.Touch.TimeToFirstScrollUpdateSwapBegin2" On 2016/10/14 18:02:49, Steven Holte ...
4 years, 2 months ago (2016-10-14 18:38:19 UTC) #8
sahel
https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2416173003/diff/1/tools/metrics/histograms/histograms.xml#oldcode13987 tools/metrics/histograms/histograms.xml:13987: -<histogram name="Event.Latency.Touch.TimeToFirstScrollUpdateSwapBegin2" On 2016/10/14 18:02:49, Steven Holte wrote: > ...
4 years, 2 months ago (2016-10-14 20:13:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416173003/40001
4 years, 2 months ago (2016-10-14 20:14:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-14 20:21:51 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 20:25:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/956857461fdc0f0d2beb304bbc96ffda398d9c37
Cr-Commit-Position: refs/heads/master@{#425452}

Powered by Google App Engine
This is Rietveld 408576698