Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2416163002: Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests. (Closed)

Created:
4 years, 2 months ago by Shanmuga Pandi
Modified:
4 years, 2 months ago
Reviewers:
Srirama, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests. BUG=636710 Committed: https://crrev.com/6f924d7bada1a44f60f566c67bd5697881ae798b Cr-Commit-Position: refs/heads/master@{#425314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -720 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html View 1 chunk +91 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html View 1 chunk +40 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html View 1 chunk +71 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html View 1 chunk +71 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html View 1 chunk +76 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Shanmuga Pandi
PTAL!!
4 years, 2 months ago (2016-10-14 05:37:43 UTC) #2
Srirama
lgtm +fs
4 years, 2 months ago (2016-10-14 09:20:33 UTC) #4
fs
lgtm
4 years, 2 months ago (2016-10-14 10:32:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416163002/1
4 years, 2 months ago (2016-10-14 11:18:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 13:56:26 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:58:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f924d7bada1a44f60f566c67bd5697881ae798b
Cr-Commit-Position: refs/heads/master@{#425314}

Powered by Google App Engine
This is Rietveld 408576698