Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2416153005: Remove usage of FOR_EACH_OBSERVER macro in content/renderer (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in content/renderer Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e Cr-Commit-Position: refs/heads/master@{#425747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -131 lines) Patch
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 4 chunks +16 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 28 chunks +93 lines, -76 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 13 chunks +30 lines, -21 lines 0 comments Download
M content/renderer/render_widget.cc View 8 chunks +20 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 22:00:37 UTC) #6
piman
LGTM and thanks for the cleanup!
4 years, 2 months ago (2016-10-17 16:54:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416153005/1
4 years, 2 months ago (2016-10-17 18:45:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:30:17 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:31:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e
Cr-Commit-Position: refs/heads/master@{#425747}

Powered by Google App Engine
This is Rietveld 408576698