Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: content/browser/device_sensors/sensor_manager_android.h

Issue 2416123003: [Device Sensors] Move Mojo communication to UI thread on Android (Closed)
Patch Set: Response to review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_sensors/sensor_manager_android.h
diff --git a/content/browser/device_sensors/sensor_manager_android.h b/content/browser/device_sensors/sensor_manager_android.h
index 6a3e45da1c317295c8b97ac5241e77fe270eeac2..01d9734782fc965aa38cf10abc3d92b38c4d305a 100644
--- a/content/browser/device_sensors/sensor_manager_android.h
+++ b/content/browser/device_sensors/sensor_manager_android.h
@@ -33,7 +33,7 @@ class CONTENT_EXPORT SensorManagerAndroid {
// Must be called at startup, before GetInstance().
static bool Register(JNIEnv* env);
- // Needs to be thread-safe, because accessed from different threads.
+ // Should be called only on the UI thread.
static SensorManagerAndroid* GetInstance();
// Called from Java via JNI.
@@ -110,20 +110,6 @@ class CONTENT_EXPORT SensorManagerAndroid {
// ConsumerType.DEVICE_MOTION.
virtual int GetNumberActiveDeviceMotionSensors();
- void StartFetchingLightDataOnUI(DeviceLightHardwareBuffer* buffer);
- void StopFetchingLightDataOnUI();
-
- void StartFetchingMotionDataOnUI(DeviceMotionHardwareBuffer* buffer);
- void StopFetchingMotionDataOnUI();
-
- void StartFetchingOrientationDataOnUI(
- DeviceOrientationHardwareBuffer* buffer);
- void StopFetchingOrientationDataOnUI();
-
- void StartFetchingOrientationAbsoluteDataOnUI(
- DeviceOrientationHardwareBuffer* buffer);
- void StopFetchingOrientationAbsoluteDataOnUI();
-
private:
friend struct base::DefaultSingletonTraits<SensorManagerAndroid>;
« no previous file with comments | « content/browser/device_sensors/device_sensor_host.cc ('k') | content/browser/device_sensors/sensor_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698