Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2416113002:
DevTools: exclude node_modules and bower_components files (Closed)
|
Created:
4 years, 2 months ago by lushnikov Modified:
4 years, 2 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: exclude node_modules and bower_components files
These folders don't contain any source code, only third-party
content.
BUG=649809
R=paulirish
Committed: https://crrev.com/aa2f0d4d0ac74793fad896c9f69947d1a2480d8d
Cr-Commit-Position: refs/heads/master@{#425231}
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, it makes. BUG=none R=paulirish, einbinder ========== to ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, it makes. BUG=none R=paulirish ==========
lushnikov@chromium.org changed reviewers: - einbinder@chromium.org
lushnikov@chromium.org changed reviewers: + dgozman@chromium.org, pfeldman@chromium.org
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
please, take a look
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, it makes. BUG=none R=paulirish ========== to ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=none R=paulirish ==========
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lushnikov@chromium.org
Description was changed from ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=none R=paulirish ========== to ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=649809 R=paulirish ==========
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=649809 R=paulirish ========== to ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=649809 R=paulirish ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=649809 R=paulirish ========== to ========== DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG=649809 R=paulirish Committed: https://crrev.com/aa2f0d4d0ac74793fad896c9f69947d1a2480d8d Cr-Commit-Position: refs/heads/master@{#425231} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/aa2f0d4d0ac74793fad896c9f69947d1a2480d8d Cr-Commit-Position: refs/heads/master@{#425231} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
