third_party/WebKit/Source/core/style/ComputedStyle.h - Issue 2416033003: Remove unsafe getFontMetrics methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2416033003: Remove unsafe getFontMetrics methods (Closed)

Patch Set: Address wkroman suggestions Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.h

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h

index a00c082f22428d1f8711190dff2b068a54952212..c1c73fbd439684a58600bfd5ed95c9d64b9f4256 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.h

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h

@@ -2514,7 +2514,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,

// Font properties.

const Font& font() const;

void setFont(const Font&);

- const FontMetrics& getFontMetrics() const;

const FontDescription& getFontDescription() const;

bool setFontDescription(const FontDescription&);

bool hasIdenticalAscentDescentAndLineGap(const ComputedStyle& other) const;