Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/style/ComputedStyle.h

Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index a00c082f22428d1f8711190dff2b068a54952212..c1c73fbd439684a58600bfd5ed95c9d64b9f4256 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -2514,7 +2514,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
   // Font properties.
   const Font& font() const;
   void setFont(const Font&);
-  const FontMetrics& getFontMetrics() const;

[wkorman, 2016/10/13 22:54:30]

Discussed in person -- an alternative approach that would save on code verbosity
at callsites could be to have something like a final-fallback dummy
PrimaryFont/FontMetrics that is implemented purely in code and returns
equivalent of zero/empty values, and return that here if we failed to load even
the single final fallback font. And then, add a separate method callsites can
use to check explicitly whether there's a real font available for retrieving
metrics or we've had to fall back to the dummy case.

However, we'd like to try this change as written for now. The above could lead
to new code not being written in a thoughtful manner, and so having a pointer
where it's clear it could be null will require authors to consider this case.

   const FontDescription& getFontDescription() const;
   bool setFontDescription(const FontDescription&);
   bool hasIdenticalAscentDescentAndLineGap(const ComputedStyle& other) const;