Remove unsafe getFontMetrics methods

third_party/WebKit/Source/platform/DragImage.cpp

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 170 matching lines @@
   result.update(nullptr);
   return result;
 }
 
 std::unique_ptr<DragImage> DragImage::create(const KURL& url,
                                              const String& inLabel,
                                              const FontDescription& systemFont,
                                              float deviceScaleFactor) {
   const Font labelFont =
       deriveDragLabelFont(kDragLinkLabelFontSize, FontWeightBold, systemFont);
+  const SimpleFontData* labelFontData = labelFont.primaryFont();
+  DCHECK(labelFontData);
   const Font urlFont =
       deriveDragLabelFont(kDragLinkUrlFontSize, FontWeightNormal, systemFont);
+  const SimpleFontData* urlFontData = urlFont.primaryFont();
+  DCHECK(urlFontData);
+
+  if (!labelFontData || !urlFontData)
+    return nullptr;
+
   FontCachePurgePreventer fontCachePurgePreventer;
 
   bool drawURLString = true;
   bool clipURLString = false;
   bool clipLabelString = false;
   float maxDragLabelStringWidthDIP =
       kMaxDragLabelStringWidth / deviceScaleFactor;
 
   String urlString = url.getString();
   String label = inLabel.stripWhiteSpace();
   if (label.isEmpty()) {
     drawURLString = false;
     label = urlString;
   }
 
   // First step is drawing the link drag image width.
   TextRun labelRun(label.impl());
   TextRun urlRun(urlString.impl());
   IntSize labelSize(labelFont.width(labelRun),
-                    labelFont.getFontMetrics().ascent() +
-                        labelFont.getFontMetrics().descent());
+                    labelFontData->getFontMetrics().ascent() +
+                        labelFontData->getFontMetrics().descent());
 
   if (labelSize.width() > maxDragLabelStringWidthDIP) {
     labelSize.setWidth(maxDragLabelStringWidthDIP);
     clipLabelString = true;
   }
 
   IntSize urlStringSize;
   IntSize imageSize(labelSize.width() + kDragLabelBorderX * 2,
                     labelSize.height() + kDragLabelBorderY * 2);
 
   if (drawURLString) {
     urlStringSize.setWidth(urlFont.width(urlRun));
-    urlStringSize.setHeight(urlFont.getFontMetrics().ascent() +
-                            urlFont.getFontMetrics().descent());
+    urlStringSize.setHeight(urlFontData->getFontMetrics().ascent() +
+                            urlFontData->getFontMetrics().descent());
     imageSize.setHeight(imageSize.height() + urlStringSize.height());
     if (urlStringSize.width() > maxDragLabelStringWidthDIP) {
       imageSize.setWidth(maxDragLabelStringWidthDIP);
       clipURLString = true;
     } else
       imageSize.setWidth(std::max(labelSize.width(), urlStringSize.width()) +
                          kDragLabelBorderX * 2);
   }
 
   // We now know how big the image needs to be, so we create and
@@ skipping 15 matching lines @@
   rrect.setRectXY(SkRect::MakeWH(imageSize.width(), imageSize.height()),
                   DragLabelRadius, DragLabelRadius);
   buffer->canvas()->drawRRect(rrect, backgroundPaint);
 
   // Draw the text
   SkPaint textPaint;
   if (drawURLString) {
     if (clipURLString)
       urlString = StringTruncator::centerTruncate(
           urlString, imageSize.width() - (kDragLabelBorderX * 2.0f), urlFont);
-    IntPoint textPos(kDragLabelBorderX,
-                     imageSize.height() - (kLabelBorderYOffset +
-                                           urlFont.getFontMetrics().descent()));
+    IntPoint textPos(
+        kDragLabelBorderX,
+        imageSize.height() -
+            (kLabelBorderYOffset + urlFontData->getFontMetrics().descent()));
     TextRun textRun(urlString);
     urlFont.drawText(buffer->canvas(), TextRunPaintInfo(textRun), textPos,
                      deviceScaleFactor, textPaint);
   }
 
   if (clipLabelString)
     label = StringTruncator::rightTruncate(
         label, imageSize.width() - (kDragLabelBorderX * 2.0f), labelFont);
 
   bool hasStrongDirectionality;
@@ skipping 29 matching lines @@
       m_interpolationQuality == InterpolationNone
           ? skia::ImageOperations::RESIZE_BOX
           : skia::ImageOperations::RESIZE_LANCZOS3;
   int imageWidth = scaleX * m_bitmap.width();
   int imageHeight = scaleY * m_bitmap.height();
   m_bitmap = skia::ImageOperations::Resize(m_bitmap, resizeMethod, imageWidth,
                                            imageHeight);
 }
 
 }  // namespace blink