Remove unsafe getFontMetrics methods

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008 Dirk Schulze <krit@webkit.org>
  * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
  * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
@@ skipping 735 matching lines @@
 TextMetrics* CanvasRenderingContext2D::measureText(const String& text) {
   TextMetrics* metrics = TextMetrics::create();
 
   // The style resolution required for fonts is not available in frame-less
   // documents.
   if (!canvas()->document().frame())
     return metrics;
 
   canvas()->document().updateStyleAndLayoutTreeForNode(canvas());
   const Font& font = accessFont();
+  const SimpleFontData* fontData = font.primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
+    return metrics;
 
   TextDirection direction;
   if (state().getDirection() == CanvasRenderingContext2DState::DirectionInherit)
     direction = determineDirectionality(text);
   else
     direction = toTextDirection(state().getDirection(), canvas());
   TextRun textRun(text, 0, 0, TextRun::AllowTrailingExpansion |
                                   TextRun::ForbidLeadingExpansion,
                   direction, false);
   textRun.setNormalizeSpace(true);
   FloatRect textBounds = font.selectionRectForText(
       textRun, FloatPoint(), font.getFontDescription().computedSize(), 0, -1,
       true);
 
   // x direction
   metrics->setWidth(font.width(textRun));
   metrics->setActualBoundingBoxLeft(-textBounds.x());
   metrics->setActualBoundingBoxRight(textBounds.maxX());
 
   // y direction
-  const FontMetrics& fontMetrics = font.getFontMetrics();
+  const FontMetrics& fontMetrics = fontData->getFontMetrics();
   const float ascent = fontMetrics.floatAscent();
   const float descent = fontMetrics.floatDescent();
   const float baselineY = getFontBaseline(fontMetrics);
 
   metrics->setFontBoundingBoxAscent(ascent - baselineY);
   metrics->setFontBoundingBoxDescent(descent + baselineY);
   metrics->setActualBoundingBoxAscent(-textBounds.y() - baselineY);
   metrics->setActualBoundingBoxDescent(textBounds.maxY() + baselineY);
 
   // Note : top/bottom and ascend/descend are currently the same, so there's no
@@ skipping 35 matching lines @@
 
   // Currently, SkPictureImageFilter does not support subpixel text
   // anti-aliasing, which is expected when !creationAttributes().alpha(), so we
   // need to fall out of display list mode when drawing text to an opaque
   // canvas. crbug.com/583809
   if (!creationAttributes().alpha() && !isAccelerated())
     canvas()->disableDeferral(
         DisableDeferralReasonSubPixelTextAntiAliasingSupport);
 
   const Font& font = accessFont();
-  if (!font.primaryFont())
+  const SimpleFontData* fontData = font.primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
     return;
-
-  const FontMetrics& fontMetrics = font.getFontMetrics();
+  const FontMetrics& fontMetrics = fontData->getFontMetrics();
 
   // FIXME: Need to turn off font smoothing.
 
   const ComputedStyle* computedStyle = 0;
   TextDirection direction =
       toTextDirection(state().getDirection(), canvas(), &computedStyle);
   bool isRTL = direction == RTL;
   bool override =
       computedStyle ? isOverride(computedStyle->unicodeBidi()) : false;
 
@@ skipping 294 matching lines @@
   }
   return true;
 }
 
 void CanvasRenderingContext2D::resetUsageTracking() {
   UsageCounters newCounters;
   m_usageCounters = newCounters;
 }
 
 }  // namespace blink