Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/paint/TextPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/TextPainter.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/frame/Settings.h"
 #include "core/layout/LayoutObject.h"
 #include "core/layout/LayoutTextCombine.h"
@@ skipping 26 matching lines @@
       m_textBounds(textBounds),
       m_horizontal(horizontal),
       m_emphasisMarkOffset(0),
       m_combinedText(0) {}
 
 TextPainter::~TextPainter() {}
 
 void TextPainter::setEmphasisMark(const AtomicString& emphasisMark,
                                   TextEmphasisPosition position) {
   m_emphasisMark = emphasisMark;
+  const SimpleFontData* fontData = m_font.primaryFont();
+  DCHECK(fontData);
 
-  if (emphasisMark.isNull()) {
+  if (!fontData || emphasisMark.isNull()) {
     m_emphasisMarkOffset = 0;
   } else if (position == TextEmphasisPositionOver) {
-    m_emphasisMarkOffset = -m_font.getFontMetrics().ascent() -
+    m_emphasisMarkOffset = -fontData->getFontMetrics().ascent() -
                            m_font.emphasisMarkDescent(emphasisMark);
   } else {
     ASSERT(position == TextEmphasisPositionUnder);
-    m_emphasisMarkOffset = m_font.getFontMetrics().descent() +
+    m_emphasisMarkOffset = fontData->getFontMetrics().descent() +
                            m_font.emphasisMarkAscent(emphasisMark);
   }
 }
 
 void TextPainter::paint(unsigned startOffset,
                         unsigned endOffset,
                         unsigned length,
                         const Style& textStyle,
                         TextBlobPtr* cachedTextBlob) {
   GraphicsContextStateSaver stateSaver(m_graphicsContext, false);
@@ skipping 180 matching lines @@
     paintInternalRun<Step>(textRunPaintInfo, startOffset, endOffset);
   } else {
     if (endOffset > 0)
       paintInternalRun<Step>(textRunPaintInfo, 0, endOffset);
     if (startOffset < truncationPoint)
       paintInternalRun<Step>(textRunPaintInfo, startOffset, truncationPoint);
   }
 }
 
 void TextPainter::paintEmphasisMarkForCombinedText() {
-  ASSERT(m_combinedText);
+  const SimpleFontData* fontData = m_font.primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
+    return;
+
+  DCHECK(m_combinedText);
   TextRun placeholderTextRun(&ideographicFullStopCharacter, 1);
   FloatPoint emphasisMarkTextOrigin(m_textBounds.x().toFloat(),
                                     m_textBounds.y().toFloat() +
-                                        m_font.getFontMetrics().ascent() +
+                                        fontData->getFontMetrics().ascent() +
                                         m_emphasisMarkOffset);
   TextRunPaintInfo textRunPaintInfo(placeholderTextRun);
   textRunPaintInfo.bounds = FloatRect(m_textBounds);
   m_graphicsContext.concatCTM(rotation(m_textBounds, Clockwise));
   m_graphicsContext.drawEmphasisMarks(m_combinedText->originalFont(),
                                       textRunPaintInfo, m_emphasisMark,
                                       emphasisMarkTextOrigin);
   m_graphicsContext.concatCTM(rotation(m_textBounds, Counterclockwise));
 }
 
 }  // namespace blink