Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/EmbeddedObjectPainter.h"
 
 #include "core/frame/Settings.h"
 #include "core/layout/LayoutEmbeddedObject.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/paint/LayoutObjectDrawingRecorder.h"
@@ skipping 36 matching lines @@
     return;
 
   LayoutRect contentRect(m_layoutEmbeddedObject.contentBoxRect());
   contentRect.moveBy(paintOffset);
   LayoutObjectDrawingRecorder drawingRecorder(context, m_layoutEmbeddedObject,
                                               paintInfo.phase, contentRect);
   GraphicsContextStateSaver stateSaver(context);
   context.clip(pixelSnappedIntRect(contentRect));
 
   Font font = replacementTextFont();
-  // TODO(trchen): Speculative fix for crbug.com/481880
-  // With last resort font, how could this ever be null?
-  ASSERT(font.primaryFont());
-  if (!font.primaryFont())
+  const SimpleFontData* fontData = font.primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
     return;
+
   TextRun textRun(m_layoutEmbeddedObject.unavailablePluginReplacementText());
-  FloatSize textGeometry(font.width(textRun), font.getFontMetrics().height());
+  FloatSize textGeometry(font.width(textRun),
+                         fontData->getFontMetrics().height());
 
   LayoutRect backgroundRect(
       0, 0,
       textGeometry.width() + 2 * replacementTextRoundedRectLeftRightTextMargin,
       replacementTextRoundedRectHeight);
   backgroundRect.move(contentRect.center() - backgroundRect.center());
   backgroundRect = LayoutRect(pixelSnappedIntRect(backgroundRect));
   Path roundedBackgroundRect;
   FloatRect floatBackgroundRect(backgroundRect);
   roundedBackgroundRect.addRoundedRect(
       floatBackgroundRect, FloatSize(replacementTextRoundedRectRadius,
                                      replacementTextRoundedRectRadius));
   context.setFillColor(
       scaleAlpha(Color::white, replacementTextRoundedRectOpacity));
   context.fillPath(roundedBackgroundRect);
 
   FloatRect textRect(FloatPoint(), textGeometry);
   textRect.move(FloatPoint(contentRect.center()) - textRect.center());
   TextRunPaintInfo runInfo(textRun);
   runInfo.bounds = floatBackgroundRect;
   context.setFillColor(scaleAlpha(Color::black, replacementTextTextOpacity));
   context.drawBidiText(
       font, runInfo,
-      textRect.location() + FloatSize(0, font.getFontMetrics().ascent()));
+      textRect.location() + FloatSize(0, fontData->getFontMetrics().ascent()));
 }
 
 }  // namespace blink