Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 672 matching lines @@
     LayoutUnit& lineBottom,
     LayoutUnit& selectionBottom,
     bool& setLineTop,
     LayoutUnit& lineTopIncludingMargins,
     LayoutUnit& lineBottomIncludingMargins,
     bool& hasAnnotationsBefore,
     bool& hasAnnotationsAfter,
     FontBaseline baselineType) {
   bool isRootBox = isRootInlineBox();
   if (isRootBox) {
-    const FontMetrics& fontMetrics =
-        getLineLayoutItem().style(isFirstLineStyle())->getFontMetrics();
+    const SimpleFontData* fontData =
+        getLineLayoutItem().style(isFirstLineStyle())->font().primaryFont();
+    DCHECK(fontData);
+    if (!fontData)
+      return;
+    const FontMetrics& fontMetrics = fontData->getFontMetrics();
     // RootInlineBoxes are always placed at pixel boundaries in their logical y
     // direction. Not doing so results in incorrect layout of text decorations,
     // most notably underlines.
     setLogicalTop(LayoutUnit(
         roundToInt(top + maxAscent - fontMetrics.ascent(baselineType))));
   }
 
   LayoutUnit adjustmentForChildrenWithSameLineHeightAndBaseline;
   if (descendantsHaveSameLineHeightAndBaseline()) {
     adjustmentForChildrenWithSameLineHeightAndBaseline = logicalTop();
@@ skipping 28 matching lines @@
       int posAdjust = maxAscent - curr->baselinePosition(baselineType);
       curr->setLogicalTop(curr->logicalTop() + top + posAdjust);
     }
 
     LayoutUnit newLogicalTop = curr->logicalTop();
     LayoutUnit newLogicalTopIncludingMargins = newLogicalTop;
     LayoutUnit boxHeight = curr->logicalHeight();
     LayoutUnit boxHeightIncludingMargins = boxHeight;
     LayoutUnit borderPaddingHeight;
     if (curr->isText() || curr->isInlineFlowBox()) {
-      const FontMetrics& fontMetrics =
-          curr->getLineLayoutItem().style(isFirstLineStyle())->getFontMetrics();
+      const SimpleFontData* fontData = curr->getLineLayoutItem()
+                                           .style(isFirstLineStyle())
+                                           ->font()
+                                           .primaryFont();
+      DCHECK(fontData);
+      if (!fontData)
+        continue;
+
+      const FontMetrics& fontMetrics = fontData->getFontMetrics();
       newLogicalTop += curr->baselinePosition(baselineType) -
                        fontMetrics.ascent(baselineType);
       if (curr->isInlineFlowBox()) {
         LineLayoutBoxModel boxObject =
             LineLayoutBoxModel(curr->getLineLayoutItem());
         newLogicalTop -= boxObject.borderAndPaddingOver();
         borderPaddingHeight = boxObject.borderAndPaddingLogicalHeight();
       }
       newLogicalTopIncludingMargins = newLogicalTop;
     } else if (!curr->getLineLayoutItem().isBR()) {
@@ skipping 876 matching lines @@
     ASSERT(child->prevOnLine() == prev);
     prev = child;
   }
   ASSERT(prev == m_lastChild);
 #endif
 }
 
 #endif
 
 }  // namespace blink