Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/layout/line/InlineBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 128 matching lines @@
           width().toFloat(), height().toFloat(),
           baselinePosition(AlphabeticBaseline),
           baselinePosition(IdeographicBaseline));
 }
 #endif
 
 LayoutUnit InlineBox::logicalHeight() const {
   if (hasVirtualLogicalHeight())
     return virtualLogicalHeight();
 
-  if (getLineLayoutItem().isText())
-    return m_bitfields.isText() ? LayoutUnit(getLineLayoutItem()
-                                                 .style(isFirstLineStyle())
-                                                 ->getFontMetrics()
-                                                 .height())
-                                : LayoutUnit();
+  const SimpleFontData* fontData =
+      getLineLayoutItem().style(isFirstLineStyle())->font().primaryFont();
+  if (getLineLayoutItem().isText()) {
+    DCHECK(fontData);
+    return m_bitfields.isText() && fontData
+               ? LayoutUnit(fontData->getFontMetrics().height())
+               : LayoutUnit();
+  }
   if (getLineLayoutItem().isBox() && parent())
     return isHorizontal() ? LineLayoutBox(getLineLayoutItem()).size().height()
                           : LineLayoutBox(getLineLayoutItem()).size().width();
 
   ASSERT(isInlineFlowBox());
   LineLayoutBoxModel flowObject = boxModelObject();
-  const FontMetrics& fontMetrics =
-      getLineLayoutItem().style(isFirstLineStyle())->getFontMetrics();
-  LayoutUnit result(fontMetrics.height());
+  DCHECK(fontData);
+  LayoutUnit result(fontData ? fontData->getFontMetrics().height() : 0);
   if (parent())
     result += flowObject.borderAndPaddingLogicalHeight();
   return result;
 }
 
 int InlineBox::baselinePosition(FontBaseline baselineType) const {
   return boxModelObject().baselinePosition(
       baselineType, m_bitfields.firstLine(),
       isHorizontal() ? HorizontalLine : VerticalLine, PositionOnContainingLine);
 }
@@ skipping 244 matching lines @@
 }
 
 void showLineTree(const blink::InlineBox* b) {
   if (b)
     b->showLineTreeForThis();
   else
     fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n");
 }
 
 #endif