Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

 /**
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2008 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 184 matching lines @@
     "#HeadLineA",
     "#PCMyungjo",
     "#PilGi",
 };
 
 // For font families where any of the fonts don't have a valid entry in the OS/2
 // table for avgCharWidth, fallback to the legacy webkit behavior of getting the
 // avgCharWidth from the width of a '0'. This only seems to apply to a fixed
 // number of Mac fonts, but, in order to get similar rendering across platforms,
 // we do this check for all platforms.
-bool LayoutTextControl::hasValidAvgCharWidth(const SimpleFontData* font,
+bool LayoutTextControl::hasValidAvgCharWidth(const SimpleFontData* fontData,
                                              const AtomicString& family) {
   // Some fonts match avgCharWidth to CJK full-width characters.
   // Heuristic check to avoid such fonts.
-  DCHECK(font);
-  const FontMetrics& metrics = font->getFontMetrics();
-  if (metrics.hasZeroWidth() &&
-      font->avgCharWidth() > metrics.zeroWidth() * 1.7)
-    return false;
+  DCHECK(fontData);
+  if (fontData) {
+    const FontMetrics& metrics = fontData->getFontMetrics();
+    if (metrics.hasZeroWidth() &&
+        fontData->avgCharWidth() > metrics.zeroWidth() * 1.7)
+      return false;
+  }
 
   static HashSet<AtomicString>* fontFamiliesWithInvalidCharWidthMap = nullptr;
 
   if (family.isEmpty())
     return false;
 
   if (!fontFamiliesWithInvalidCharWidthMap) {
     fontFamiliesWithInvalidCharWidthMap = new HashSet<AtomicString>;
 
     for (size_t i = 0; i < WTF_ARRAY_LENGTH(fontFamiliesWithInvalidCharWidth);
@@ skipping 100 matching lines @@
   LayoutObject* placeholderLayoutObject =
       placeholder ? placeholder->layoutObject() : nullptr;
   if (!placeholderLayoutObject)
     return nullptr;
   if (relayoutChildren)
     layoutScope.setChildNeedsLayout(placeholderLayoutObject);
   return placeholderLayoutObject;
 }
 
 }  // namespace blink