Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/layout/LayoutText.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 1298 matching lines @@
 
   if (!styleToUse.autoWrap())
     m_minWidth = m_maxWidth;
 
   if (styleToUse.whiteSpace() == PRE) {
     if (firstLine)
       m_firstLineMinWidth = m_maxWidth;
     m_lastLineLineMinWidth = currMaxWidth;
   }
 
+  const SimpleFontData* fontData = f.primaryFont();
+  DCHECK(fontData);
+
   GlyphOverflow glyphOverflow;
-  glyphOverflow.setFromBounds(glyphBounds, f.getFontMetrics().floatAscent(),
-                              f.getFontMetrics().floatDescent(), m_maxWidth);
+  if (fontData) {
+    glyphOverflow.setFromBounds(
+        glyphBounds, fontData->getFontMetrics().floatAscent(),
+        fontData->getFontMetrics().floatDescent(), m_maxWidth);
+  }
   // We shouldn't change our mind once we "know".
   ASSERT(!m_knownToHaveNoOverflowAndNoFallbackFonts ||
          (fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero()));
   m_knownToHaveNoOverflowAndNoFallbackFonts =
       fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero();
 
   clearPreferredLogicalWidthsDirty();
 }
 
 bool LayoutText::isAllCollapsibleWhitespace() const {
@@ skipping 376 matching lines @@
                         unsigned len,
                         const Font& f,
                         LayoutUnit xPos,
                         TextDirection textDirection,
                         HashSet<const SimpleFontData*>* fallbackFonts,
                         FloatRect* glyphBounds) const {
   ASSERT(from + len <= textLength());
   if (!textLength())
     return 0;
 
+  const SimpleFontData* fontData = f.primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
+    return 0;
+
   float w;
   if (&f == &style()->font()) {
     if (!style()->preserveNewline() && !from && len == textLength()) {
       if (fallbackFonts) {
         ASSERT(glyphBounds);
         if (preferredLogicalWidthsDirty() ||
             !m_knownToHaveNoOverflowAndNoFallbackFonts)
           const_cast<LayoutText*>(this)->computePreferredLogicalWidths(
               0, *fallbackFonts, *glyphBounds);
         else
           *glyphBounds =
-              FloatRect(0, -f.getFontMetrics().floatAscent(), m_maxWidth,
-                        f.getFontMetrics().floatHeight());
+              FloatRect(0, -fontData->getFontMetrics().floatAscent(),
+                        m_maxWidth, fontData->getFontMetrics().floatHeight());
         w = m_maxWidth;
       } else {
         w = maxLogicalWidth();
       }
     } else {
       w = widthFromFont(f, from, len, xPos.toFloat(), 0, textDirection,
                         fallbackFonts, glyphBounds);
     }
   } else {
     TextRun run =
@@ skipping 200 matching lines @@
   LayoutRect rect = LayoutRect(
       IntRect(firstRunX(), firstRunY(), linesBox.width(), linesBox.height()));
   LayoutBlock* block = containingBlock();
   if (block && hasTextBoxes())
     block->adjustChildDebugRect(rect);
 
   return rect;
 }
 
 }  // namespace blink