Remove unsafe getFontMetrics methods

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2469 matching lines @@
       break;
   }
   return count;
 }
 
 int LayoutBlockFlow::firstLineBoxBaseline() const {
   if (isWritingModeRoot() && !isRubyRun())
     return -1;
   if (!childrenInline())
     return LayoutBlock::firstLineBoxBaseline();
-  if (firstLineBox())
+  if (firstLineBox()) {
+    const SimpleFontData* fontData = style(true)->font().primaryFont();
+    DCHECK(fontData);
+    if (!fontData)
+      return -1;
     return (firstLineBox()->logicalTop() +
-            style(true)->getFontMetrics().ascent(
-                firstRootBox()->baselineType()))
+            fontData->getFontMetrics().ascent(firstRootBox()->baselineType()))
         .toInt();
+  }
   return -1;
 }
 
 int LayoutBlockFlow::inlineBlockBaseline(
     LineDirectionMode lineDirection) const {
   // CSS2.1 states that the baseline of an 'inline-block' is:
   // the baseline of the last line box in the normal flow, unless it has
   // either no in-flow line boxes or if its 'overflow' property has a computed
   // value other than 'visible', in which case the baseline is the bottom
   // margin edge.
   // We likewise avoid using the last line box in the case of size containment,
   // where the block's contents shouldn't be considered when laying out its
   // ancestors or siblings.
 
   if ((!style()->isOverflowVisible() &&
        !shouldIgnoreOverflowPropertyForInlineBlockBaseline()) ||
       style()->containsSize()) {
     // We are not calling baselinePosition here because the caller should add
     // the margin-top/margin-right, not us.
     return (lineDirection == HorizontalLine ? size().height() + marginBottom()
                                             : size().width() + marginLeft())
         .toInt();
   }
   if (isWritingModeRoot() && !isRubyRun())
     return -1;
   if (!childrenInline())
     return LayoutBlock::inlineBlockBaseline(lineDirection);
-  if (lastLineBox())
+  if (lastLineBox()) {
+    const SimpleFontData* fontData =
+        style(lastLineBox() == firstLineBox())->font().primaryFont();
+    DCHECK(fontData);
+    if (!fontData)
+      return -1;
     return (lastLineBox()->logicalTop() +
-            style(lastLineBox() == firstLineBox())
-                ->getFontMetrics()
-                .ascent(lastRootBox()->baselineType()))
+            fontData->getFontMetrics().ascent(lastRootBox()->baselineType()))
         .toInt();
+  }
   if (!hasLineIfEmpty())
     return -1;
-  const FontMetrics& fontMetrics = firstLineStyle()->getFontMetrics();
+
+  const SimpleFontData* fontData = firstLineStyle()->font().primaryFont();
+  DCHECK(fontData);
+  if (!fontData)
+    return -1;
+
+  const FontMetrics& fontMetrics = fontData->getFontMetrics();
   return (fontMetrics.ascent() +
           (lineHeight(true, lineDirection, PositionOfInteriorLineBoxes) -
            fontMetrics.height()) /
               2 +
           (lineDirection == HorizontalLine ? borderTop() + paddingTop()
                                            : borderRight() + paddingRight()))
       .toInt();
 }
 
 void LayoutBlockFlow::removeFloatingObjectsFromDescendants() {
@@ skipping 1979 matching lines @@
   return LayoutBlock::invalidatePaintIfNeeded(paintInvalidationState);
 }
 
 void LayoutBlockFlow::invalidateDisplayItemClients(
     PaintInvalidationReason invalidationReason) const {
   BlockFlowPaintInvalidator(*this).invalidateDisplayItemClients(
       invalidationReason);
 }
 
 }  // namespace blink