Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2415983002: Move page_transition_util to components/arc/intent_helper/ (Closed)

Created:
4 years, 2 months ago by Yusuke Sato
Modified:
4 years, 2 months ago
Reviewers:
hidehiko, xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move page_transition_util to components/arc/intent_helper/ The files have neither chrome nor content dependency, and hence can live in components/. BUG=None TEST=try Committed: https://crrev.com/551b02d67966d8b68552da7c2b490e9bf0b9411a Cr-Commit-Position: refs/heads/master@{#425367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -199 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/arc/page_transition_util.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/chromeos/arc/page_transition_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/chromeos/arc/page_transition_util_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + components/arc/intent_helper/page_transition_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/arc/intent_helper/page_transition_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/arc/intent_helper/page_transition_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Yusuke Sato
PTAL
4 years, 2 months ago (2016-10-13 23:20:42 UTC) #6
hidehiko
4 years, 2 months ago (2016-10-13 23:23:03 UTC) #7
hidehiko
lgtm
4 years, 2 months ago (2016-10-13 23:23:05 UTC) #8
Yusuke Sato
+xiyuan Please take a look at c/b/chromeos/BUILD.gn.
4 years, 2 months ago (2016-10-13 23:26:52 UTC) #10
xiyuan
c/b/chromeos/BUILD.gn lgtm
4 years, 2 months ago (2016-10-14 16:59:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415983002/1
4 years, 2 months ago (2016-10-14 17:04:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 17:12:35 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:16:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/551b02d67966d8b68552da7c2b490e9bf0b9411a
Cr-Commit-Position: refs/heads/master@{#425367}

Powered by Google App Engine
This is Rietveld 408576698