Fix compile on the Blimp Client Engine Integration bot

scripts/slave/recipes/blimp/integration.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 from recipe_engine.recipe_api import Property
 from recipe_engine.types import freeze
 
 DEPS = [
   'chromium',
@@ skipping 21 matching lines @@
       'gclient_apply_config': 'android',
       'gclient_config': 'chromium',
       'target': 'Debug',
     },
   },
 })
 
 REPO_URL = 'https://chromium.googlesource.com/chromium/src.git'
 
 def RunSteps(api):
-  android_build = api.path['slave_build'].join('src', 'out-android', 'Debug')
-  linux_build = api.path['slave_build'].join('src', 'out-linux', 'Debug')
+  android_build = api.path['checkout'].join('src', 'out-android')

[mikecase (-- gone --), 2016/10/14 02:25:36]

need to change these paths to api.path['checkout'].join('out-android')

remove the src/

If you look in the expectation files there is src/src/

[shenghuazhang, 2016/10/14 03:21:19]

Done.

+  linux_build = api.path['checkout'].join('src', 'out-linux')
   mastername = api.properties.get('mastername')
   buildername = api.properties.get('buildername')
   builder = BUILDERS[mastername][buildername]
   api.chromium_android.configure_from_properties(
       builder['config'],
       REPO_NAME='src',
       REPO_URL=REPO_URL,
       INTERNAL=False,
       BUILD_CONFIG=builder['target'])
 
   api.chromium.set_config('chromium')

[mikecase (-- gone --), 2016/10/14 02:25:36]

The fix you want is to delete this line. Looks like it sets "Release" by default
and overrides the fact Debug is set by your call to
api.chromium_android.configure_from_properties().

[shenghuazhang, 2016/10/14 03:21:18]

Ohhh yes you are right... Or, maybe could call chromium.set_config  before
api.chromium_android.configure_from_properties()? I found something similar
like:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/...

   api.gclient.set_config(builder['gclient_config'])
   api.gclient.apply_config(builder['gclient_apply_config'])
   api.bot_update.ensure_checkout()
   api.chromium.ensure_goma()
   api.chromium_android.clean_local_files()
   api.chromium.runhooks()
 
   api.chromium.run_mb(mastername=mastername,
                       buildername=buildername,
                       build_dir=linux_build,
                       phase='engine')
   api.chromium.compile(targets=['blimp'],
+                       target=builder['target'],

[mikecase (-- gone --), 2016/10/14 02:25:36]

you don't need to specify this explicitly. This does fix the problem, but isnt
the fix you want/

[shenghuazhang, 2016/10/14 03:21:19]

Done.

                        out_dir=linux_build)
   api.chromium.run_mb(mastername=mastername,
                       buildername=buildername,
                       build_dir=android_build,
                       phase='client')
   api.chromium.compile(targets=['blimp', 'chrome_public_apk'],
+                       target=builder['target'],
                        out_dir=android_build)
 
 
 def GenTests(api):
   sanitize = lambda s: ''.join(c if c.isalnum() else '_' for c in s)
 
   yield (
       api.test('%s_test_pass' % sanitize('Blimp Android Tester')) +
       api.properties.generic(
         buildername='Blimp Client Engine Integration',
         mastername='chromium.fyi')
   )