third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js - Issue 2415933003: DevTools: explicitly reveal the stack frame location upon click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2415933003: DevTools: explicitly reveal the stack frame location upon click. (Closed)

Patch Set: removed the check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

index 3b6b525f7e1b1c0a406c92c5cf409a005432ece1..c567449b90eb5165f9217788b738974580c84119 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

@@ -415,6 +415,8 @@ WebInspector.CallStackSidebarPane.prototype = {

WebInspector.context.setFlavor(WebInspector.DebuggerModel.CallFrame, callFrame);

callFrame.debuggerModel.setSelectedCallFrame(callFrame);

+ var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(callFrame.location());

kozy 2016/10/13 22:56:54 Can we reveal location only if current flavor(WebI

+ WebInspector.Revealer.reveal(uiLocation);

_copyStackTrace: function()

« no previous file with comments | « no previous file | no next file » | no next file with comments »