Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2415933003: DevTools: explicitly reveal the stack frame location upon click. (Closed)
Patch Set: removed the check Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 408
409 for (var i = 0; i < this.callFrames.length; ++i) { 409 for (var i = 0; i < this.callFrames.length; ++i) {
410 var callFrameItem = this.callFrames[i]; 410 var callFrameItem = this.callFrames[i];
411 callFrameItem.setSelected(callFrameItem === selectedCallFrame); 411 callFrameItem.setSelected(callFrameItem === selectedCallFrame);
412 if (callFrameItem.isSelected() && callFrameItem.isHidden()) 412 if (callFrameItem.isSelected() && callFrameItem.isHidden())
413 this._revealHiddenCallFrames(); 413 this._revealHiddenCallFrames();
414 } 414 }
415 415
416 WebInspector.context.setFlavor(WebInspector.DebuggerModel.CallFrame, cal lFrame); 416 WebInspector.context.setFlavor(WebInspector.DebuggerModel.CallFrame, cal lFrame);
417 callFrame.debuggerModel.setSelectedCallFrame(callFrame); 417 callFrame.debuggerModel.setSelectedCallFrame(callFrame);
418 var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILo cation(callFrame.location());
kozy 2016/10/13 22:56:54 Can we reveal location only if current flavor(WebI
419 WebInspector.Revealer.reveal(uiLocation);
418 }, 420 },
419 421
420 _copyStackTrace: function() 422 _copyStackTrace: function()
421 { 423 {
422 var text = ""; 424 var text = "";
423 var lastCallFrame = null; 425 var lastCallFrame = null;
424 for (var i = 0; i < this.callFrames.length; ++i) { 426 for (var i = 0; i < this.callFrames.length; ++i) {
425 var callFrame = this.callFrames[i]; 427 var callFrame = this.callFrames[i];
426 if (callFrame.isHidden()) 428 if (callFrame.isHidden())
427 continue; 429 continue;
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 var uiLocation = liveLocation.uiLocation(); 491 var uiLocation = liveLocation.uiLocation();
490 if (!uiLocation) 492 if (!uiLocation)
491 return; 493 return;
492 var text = uiLocation.linkText(); 494 var text = uiLocation.linkText();
493 this.setSubtitle(text.trimMiddle(30)); 495 this.setSubtitle(text.trimMiddle(30));
494 this.subtitleElement.title = text; 496 this.subtitleElement.title = text;
495 }, 497 },
496 498
497 __proto__: WebInspector.UIList.Item.prototype 499 __proto__: WebInspector.UIList.Item.prototype
498 } 500 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698