Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: components/prefs/pref_notifier_impl_unittest.cc

Issue 2415793002: Remove usage of base::ObserverList<T>::Iter::GetNext() in //components/prefs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/prefs/pref_notifier_impl_unittest.cc
diff --git a/components/prefs/pref_notifier_impl_unittest.cc b/components/prefs/pref_notifier_impl_unittest.cc
index 517a403936aaed88da382d4d1ec0a561f978dc80..06ab053045c5e02198741708edcd13b59794c1fb 100644
--- a/components/prefs/pref_notifier_impl_unittest.cc
+++ b/components/prefs/pref_notifier_impl_unittest.cc
@@ -59,12 +59,9 @@ class MockPrefNotifier : public PrefNotifierImpl {
if (observer_iterator == pref_observers()->end())
return false;
- PrefObserverList* observer_list = observer_iterator->second.get();
- PrefObserverList::Iterator it(observer_list);
- PrefObserver* existing_obs;
size_t count = 0;
- while ((existing_obs = it.GetNext()) != NULL) {
- if (existing_obs == obs)
+ for (auto& existing_obs : *observer_iterator->second) {
+ if (&existing_obs == obs)
count++;
}
« components/prefs/pref_notifier_impl.cc ('K') | « components/prefs/pref_notifier_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698