Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2515)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

Issue 2415783003: CL for src perf tryjob to run system_health.common_desktop benchmark on all-win platform(s) (Closed)
Patch Set: CL for src perf tryjob to run system_health.memory_desktop benchmark on all-win platform(s) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
index 45fb5ef399c9f272d4b5828fe72f112bed11aca0..b910c8a92e2dfcd925157d7d81acdbc401294555 100644
--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
@@ -66,6 +66,7 @@ void PreferenceValidationDelegate::OnAtomicPreferenceValidation(
bool is_personal) {
TPIncident_ValueState proto_value_state =
MapValueState(value_state, external_validation_value_state);
+
if (proto_value_state != TPIncident::UNKNOWN) {
std::unique_ptr<TPIncident> incident(
new ClientIncidentReport_IncidentData_TrackedPreferenceIncident());
@@ -76,6 +77,9 @@ void PreferenceValidationDelegate::OnAtomicPreferenceValidation(
incident->clear_atomic_value();
}
incident->set_value_state(proto_value_state);
+
+ NOTREACHED() << "Incident shouldn't be triggered from try bot. DO NOT SUBMIT." << pref_path;
+
incident_receiver_->AddIncidentForProfile(
profile_, base::MakeUnique<TrackedPreferenceIncident>(
std::move(incident), is_personal));
@@ -110,6 +114,9 @@ void PreferenceValidationDelegate::OnSplitPreferenceValidation(
incident->add_split_key(*scan);
}
}
+
+ NOTREACHED() << "Incident shouldn't be triggered from try bot. DO NOT SUBMIT." << pref_path;
+
incident->set_value_state(proto_value_state);
incident_receiver_->AddIncidentForProfile(
profile_, base::MakeUnique<TrackedPreferenceIncident>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698