Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2415783002: [Mac] Pass YES to activateIgnoringOtherApps: to actually activate Chrome. (Closed)

Created:
4 years, 2 months ago by Robert Sesek
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Mac] Pass YES to activateIgnoringOtherApps: to actually activate Chrome. Passing NO doesn't activate our app in most cases; it seems to be mainly useful when an app is launched (so there may be a long delay before it's ready to become active) but the user might have switched to another app in the mean time. In that case, the activation isn't the immediate result of a user gesture, so it shouldn't steal focus. This is a recent regression from crrev.com/2386343004. BUG=654441, 653483, 650845 Review-Url: https://codereview.chromium.org/2409623002 Cr-Commit-Position: refs/heads/master@{#424182} (cherry picked from commit d694190ff0e1e1d594ccd644f807a1309ee61d5e) Committed: https://chromium.googlesource.com/chromium/src/+/dcb9b2152f0875df5fa0352b92da1ee97e2bba89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_utils.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Robert Sesek
4 years, 2 months ago (2016-10-12 23:21:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcb9b2152f0875df5fa0352b92da1ee97e2bba89.

Powered by Google App Engine
This is Rietveld 408576698