Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2415753002: Remove usage of base::ObserverList<T>::Iter::GetNext() in //remoting. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of base::ObserverList<T>::Iter::GetNext() in //remoting. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1 Cr-Commit-Position: refs/heads/master@{#425463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M remoting/host/register_support_host_request_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M remoting/signaling/delegating_signal_strategy.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-10-12 22:52:04 UTC) #4
kelvinp
lgtm
4 years, 2 months ago (2016-10-14 18:48:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415753002/1
4 years, 2 months ago (2016-10-14 20:22:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 21:17:11 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 21:19:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1
Cr-Commit-Position: refs/heads/master@{#425463}

Powered by Google App Engine
This is Rietveld 408576698