Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2415743004: Fix assertion failure with deferred prefixes. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix assertion failure with deferred prefixes. When running with --load-deferred-eagerly, we don't need to collect functions for invalidation, but instead insert runtime checks if the prefix if loadLibrary was called loaded or not. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a0380ffaf6e13804848fe9d67d651ade85340dee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/parser.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 2 months ago (2016-10-14 17:18:46 UTC) #2
rmacnak
lgtm
4 years, 2 months ago (2016-10-14 17:19:20 UTC) #3
Florian Schneider
4 years, 2 months ago (2016-10-14 17:20:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0380ffaf6e13804848fe9d67d651ade85340dee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698