Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

Issue 2415723002: [Blink, RemotePlayback] watchAvailability() implementation. (Closed)
Patch Set: Added layout test for callback gc Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
index 9f83a7e288d5a716902d9ce1426f4b8f8821e1d0..9039d78c99b513c542a462d89ed9ff6822ca80fc 100644
--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
@@ -59,7 +59,8 @@ TEST_F(RemotePlaybackTest, PromptCancelledRejectsWithNotAllowedError) {
auto pageHolder = DummyPageHolder::create();
HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
- RemotePlayback* remotePlayback = RemotePlayback::create(*element);
+ RemotePlayback* remotePlayback =
+ RemotePlayback::create(scope.getScriptState(), *element);
MockFunction* resolve = MockFunction::create(scope.getScriptState());
MockFunction* reject = MockFunction::create(scope.getScriptState());
@@ -67,8 +68,7 @@ TEST_F(RemotePlaybackTest, PromptCancelledRejectsWithNotAllowedError) {
EXPECT_CALL(*resolve, call(::testing::_)).Times(0);
EXPECT_CALL(*reject, call(::testing::_)).Times(1);
- remotePlayback->prompt(scope.getScriptState())
- .then(resolve->bind(), reject->bind());
+ remotePlayback->prompt().then(resolve->bind(), reject->bind());
cancelPrompt(remotePlayback);
}
@@ -78,7 +78,8 @@ TEST_F(RemotePlaybackTest, StateChangeEvents) {
auto pageHolder = DummyPageHolder::create();
HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
- RemotePlayback* remotePlayback = RemotePlayback::create(*element);
+ RemotePlayback* remotePlayback =
+ RemotePlayback::create(scope.getScriptState(), *element);
auto connectingHandler = new ::testing::StrictMock<MockEventListener>();
auto connectHandler = new ::testing::StrictMock<MockEventListener>();
« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698