Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2415703002: Move files video_capture*.* from media/base to media/capture (Closed)

Created:
4 years, 2 months ago by chfremer
Modified:
4 years, 1 month ago
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, mac-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files video_capture*.* from media/base to media/capture * Moved files video_capture*.* from media/base to media/capture * Split out video capture related part from media/base/ipc/media_param_traits* into new files media/capture/ipc/capture_param_traits*. * Added include for newly created file to content/common/view_messages.h This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.7.2pre. This is in preparation for CL1.7.2, see [2]. BUG=584797 TEST=media_unittests, content_unittests, capture_unittests [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://codereview.chromium.org/2405423002/ Committed: https://crrev.com/004926e6a8230f3e26bc5ade150b71133932c86f Cr-Commit-Position: refs/heads/master@{#427142}

Patch Set 1 #

Patch Set 2 : Add newly added file to include collection to make it get pulled in by ipc_fuzzer. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -562 lines) Patch
M chrome/renderer/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/cast_receiver_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_receiver_session_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/video_capture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/video_capture.typemap View 1 chunk +1 line, -1 line 0 comments Download
M content/common/video_capture_struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/media_stream_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/media_stream_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/canvas_capture_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/html_video_element_capturer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capturer_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/pepper_to_video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_to_pepper_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_camera_device.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/base/BUILD.gn View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/ipc/media_param_traits.h View 2 chunks +0 lines, -12 lines 0 comments Download
M media/base/ipc/media_param_traits.cc View 3 chunks +0 lines, -36 lines 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
D media/base/video_capture_types.h View 1 chunk +0 lines, -150 lines 0 comments Download
D media/base/video_capture_types.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D media/base/video_capturer_source.h View 1 chunk +0 lines, -121 lines 0 comments Download
D media/base/video_capturer_source.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M media/capture/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/capture/content/capture_resolution_chooser.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/content/thread_safe_capture_oracle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/capture/ipc/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A media/capture/ipc/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + media/capture/ipc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/capture/ipc/capture_param_traits.h View 2 chunks +12 lines, -7 lines 0 comments Download
A media/capture/ipc/capture_param_traits.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A media/capture/ipc/capture_param_traits_macros.h View 1 chunk +13 lines, -0 lines 0 comments Download
M media/capture/video/blob_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/file_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_factory_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_buffer_pool.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_buffer_pool_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_buffer_tracker.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_buffer_tracker_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/win/capability_list_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/capability_list_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/sink_filter_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/sink_input_pin_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
A + media/capture/video_capture_types.h View 4 chunks +7 lines, -8 lines 0 comments Download
A + media/capture/video_capture_types.cc View 5 chunks +8 lines, -17 lines 0 comments Download
A + media/capture/video_capturer_source.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + media/capture/video_capturer_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/public/interfaces/video_capture_device_proxy.typemap View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/public/interfaces/video_capture_device_proxy_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/public/interfaces/video_capture_format.typemap View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/public/interfaces/video_capture_format_traits.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_device_proxy_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (22 generated)
chfremer
PTAL
4 years, 2 months ago (2016-10-12 21:42:03 UTC) #6
xhwang
thank! media/ excluding media/capture/ lgtm % compile errors
4 years, 2 months ago (2016-10-12 21:51:48 UTC) #9
mcasas
On 2016/10/12 21:51:48, xhwang wrote: > thank! media/ excluding media/capture/ lgtm % compile errors not ...
4 years, 2 months ago (2016-10-12 22:21:28 UTC) #10
Ken Rockot(use gerrit already)
rs lgtm
4 years, 2 months ago (2016-10-18 16:05:52 UTC) #16
chfremer
ben@ Please RS the following: chrome/*, content/browser/media/*, content/common/media/video_capture.h, content/common/video_capture.typemap, content/public/* content/renderer/pepper/* content/shell/* tsepez@ Please RS ...
4 years, 2 months ago (2016-10-18 16:28:18 UTC) #18
chfremer
On 2016/10/18 16:28:18, chfremer wrote: > ben@ Please RS the following: > chrome/*, > content/browser/media/*, ...
4 years, 2 months ago (2016-10-21 15:33:19 UTC) #20
Tom Sepez
RS LGTM
4 years, 2 months ago (2016-10-21 16:46:21 UTC) #21
Ben Goodger (Google)
rs lgtm
4 years, 1 month ago (2016-10-24 17:35:58 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415703002/60001
4 years, 1 month ago (2016-10-24 20:33:28 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-24 20:53:18 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:55:25 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/004926e6a8230f3e26bc5ade150b71133932c86f
Cr-Commit-Position: refs/heads/master@{#427142}

Powered by Google App Engine
This is Rietveld 408576698