Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2415683002:
Make telemetry use the same chrome stable build as tracing/dashboard. (Closed)
|
Created:
4 years, 2 months ago by aiolos (Not reviewing) Modified:
4 years ago CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionMake telemetry use the same chrome stable build as tracing/dashboard.
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ca719be61d3204f1d4b7e4ed1f8130b840d5cc96
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/287f4bd6afc9b828782d5910b9a8b05c7b698ab9
Patch Set 1 #
Messages
Total messages: 35 (23 generated)
aiolos@chromium.org changed reviewers: + eakuefner@chromium.org
The CQ bit was checked by aiolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
lgtm, make sure to email perf-sheriffs@
On 2016/10/12 21:05:06, eakuefner wrote: > lgtm, make sure to email perf-sheriffs@ lgtm, should we also remove the reference_build entries from chrome_binaries.json?
eakuefner@chromium.org changed reviewers: + nednguyen@google.com
ping -- you gonna land this?
The CQ bit was checked by aiolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480711684349740, "parent_rev":
"d148b6fd62854cdbc4ae68e892f2bb85f6a26dc9", "commit_rev":
"ca719be61d3204f1d4b7e4ed1f8130b840d5cc96"}
Message was sent while issue was closed.
Description was changed from ========== Make telemetry use the same chrome stable build as tracing/dashboard. ========== to ========== Make telemetry use the same chrome stable build as tracing/dashboard. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2549913002/ by aiolos@chromium.org. The reason for reverting is: Telemetry desktop browser finder tests are failing on other cls. Speculatively reverting to see if this is the cause..
Message was sent while issue was closed.
Description was changed from ========== Make telemetry use the same chrome stable build as tracing/dashboard. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ========== to ========== Make telemetry use the same chrome stable build as tracing/dashboard. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
On 2016/12/02 22:54:50, aiolos wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2549913002/ by mailto:aiolos@chromium.org. > > The reason for reverting is: Telemetry desktop browser finder tests are failing > on other cls. Speculatively reverting to see if this is the cause.. Relanding. It's unclear whether this cl caused the failures, and landing it appears to have fixed https://bugs.chromium.org/p/chromium/issues/detail?id=670797
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)
The CQ bit was checked by aiolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aiolos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480975924524950, "parent_rev":
"164bf63357efa29afed6c490d549312cc075fa3c", "commit_rev":
"287f4bd6afc9b828782d5910b9a8b05c7b698ab9"}
Message was sent while issue was closed.
Description was changed from ========== Make telemetry use the same chrome stable build as tracing/dashboard. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ========== to ========== Make telemetry use the same chrome stable build as tracing/dashboard. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
