Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2415673002: Fix double-accounting of SkPictureShader bitmap memory (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org, ssid
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix double-accounting of SkPictureShader bitmap memory The pixels RAM is accounted via SkImageGenerator/SkImageCacherator, we don't need to report it as part of SkPictureShader's BitmapShaderRec. R=reed@google.com BUG=chromium:619929 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415673002 Committed: https://skia.googlesource.com/skia/+/c9a9ca934b936512a486674cfe06fd1c132b4723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/core/SkPictureShader.cpp View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
4 years, 2 months ago (2016-10-12 18:52:13 UTC) #3
reed1
lgtm
4 years, 2 months ago (2016-10-12 19:21:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415673002/1
4 years, 2 months ago (2016-10-12 20:23:50 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 20:43:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c9a9ca934b936512a486674cfe06fd1c132b4723

Powered by Google App Engine
This is Rietveld 408576698