[regexp] RegExp.prototype.replace fast-paths

[regexp] RegExp.prototype.replace fast-paths

This CL adds two new fast-paths for RegExp.prototype.replace in the case
that the regexp itself is an unmodified JSRegExp instance and the
replace argument is callable. Such cases call directly into runtime.

This could be improved even further by turning the relevant runtime
functions into inline TurboFan.

BUG=v8:5339
Committed: https://crrev.com/7a75f34b20487f72f2de9baf7cd5871fe925c969
Cr-Commit-Position: refs/heads/master@{#40381}

[jgruber, 2016-10-14 14:02:37]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 14:02:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 14:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 14:09:57]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jgruber, 2016-10-15 09:58:14]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 09:58:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 10:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 10:04:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jgruber, 2016-10-15 10:09:02]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 10:09:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 10:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 10:35:28]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-10-15 18:23:17]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-15 18:23:18]

This is a first step towards faster replace with functional args. The next step
is to TurboFan the non-global case.

https://codereview.chromium.org/2415663007/diff/40001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2415663007/diff/40001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:794: a->Return(a->Select(is_flag_set,
a->TrueConstant(), a->FalseConstant()));
TODO(me): Is this equivalent to a->Return(is_flag_set)?

[Yang, 2016-10-17 13:30:54]

lgtm

https://codereview.chromium.org/2415663007/diff/40001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2415663007/diff/40001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:794: a->Return(a->Select(is_flag_set,
a->TrueConstant(), a->FalseConstant()));
On 2016/10/15 18:23:18, jgruber wrote:
> TODO(me): Is this equivalent to a->Return(is_flag_set)?

Pretty sure you need to use Select, which turns the condition into branches.

[jgruber, 2016-10-18 06:47:11]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-10-18 06:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 07:15:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 07:16:24]

Description was changed from

==========
[regexp] RegExp.prototype.replace fast-paths

This CL adds two new fast-paths for RegExp.prototype.replace in the case
that the regexp itself is an unmodified JSRegExp instance and the
replace argument is callable. Such cases call directly into runtime.

This could be improved even further by turning the relevant runtime
functions into inline TurboFan.

BUG=v8:5339
==========

to

==========
[regexp] RegExp.prototype.replace fast-paths

This CL adds two new fast-paths for RegExp.prototype.replace in the case
that the regexp itself is an unmodified JSRegExp instance and the
replace argument is callable. Such cases call directly into runtime.

This could be improved even further by turning the relevant runtime
functions into inline TurboFan.

BUG=v8:5339

Committed: https://crrev.com/7a75f34b20487f72f2de9baf7cd5871fe925c969
Cr-Commit-Position: refs/heads/master@{#40381}
==========

[commit-bot: I haz the power, 2016-10-18 07:16:24]

Patchset 3 (id:??) landed as
https://crrev.com/7a75f34b20487f72f2de9baf7cd5871fe925c969
Cr-Commit-Position: refs/heads/master@{#40381}