Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2415663006: 📰 Fix the calculation of the height of the bottom spacer (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Fix the calculation of the height of the bottom spacer Switch to using the bottom of the last content item instead of the top of the bottom spacer. Because the bottom spacer is not visible when we do the calculation, its properties are not up to date, and it makes the calculations return wrong results. BUG=655514 Committed: https://crrev.com/4039a5af707d0f8770fc3339143041193af99064 Cr-Commit-Position: refs/heads/master@{#425313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgn
PTAL
4 years, 2 months ago (2016-10-14 12:09:09 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-14 13:40:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415663006/1
4 years, 2 months ago (2016-10-14 13:41:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 13:47:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:51:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4039a5af707d0f8770fc3339143041193af99064
Cr-Commit-Position: refs/heads/master@{#425313}

Powered by Google App Engine
This is Rietveld 408576698