Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2415653002: Fix library name insert and access inconsistency on windows (Closed)

Created:
4 years, 2 months ago by nshahan
Modified:
4 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix library name insert and access inconsistency on windows Make naming of libraries on windows consistent with the behaivor on linux and mac. Fixes #27576 R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d8505ee2644ae4411dfade6631acd2b2e8a4fd27

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 5 (3 generated)
vsm
lgtm https://codereview.chromium.org/2415653002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2415653002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode5464 pkg/dev_compiler/lib/src/compiler/code_generator.dart:5464: fromUri(uri).substring(libraryRoot.length).replaceAll(separator, customSeparator); Can you run ./tool/format.sh ? It ...
4 years, 2 months ago (2016-10-12 20:32:05 UTC) #3
nshahan
4 years, 2 months ago (2016-10-12 21:14:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8505ee2644ae4411dfade6631acd2b2e8a4fd27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698