blimp: Add mode to use the updated compositing path on the client.

blimp: Add mode to use the updated compositing path on the client.

Sets up the code to use a threaded LayerTreeHost on the BlimpCompositor
on the client. The compositor now creates a threaded
LayerTreeHostInProcess. The flow of updates is as follows:

1) The engine will send a frame update in the CompositorMessage.
2) On receiving the update, the client requests the LayerTreeHost to
schedule a main frame.
3) When the LayerTreeHost asks its client to update its state, the
frame update in the proto is deserialized using the
CompositorStateDeserializer.

BUG=648442
Committed: https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4
Cr-Commit-Position: refs/heads/master@{#427597}

[Khushal, 2016-10-13 04:25:08]

khushalsagar@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Khushal, 2016-10-13 04:25:09]

I tested with the engine side patch and it works. \o/

After this the only thing left is the hook-up for scroll and scale sync.

[Khushal, 2016-10-13 04:25:15]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 04:25:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 04:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 04:29:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-10-13 04:30:59]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 04:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 04:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 04:34:56]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-10-13 04:40:35]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 04:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 05:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 05:32:24]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-10-13 15:18:41]

awesome!  yeah this looks great.  nits but lgtm.

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor.cc (right):

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor.cc:369: if
(!use_threaded_layer_tree_host_)
{} if the line wraps?  Would feel cleaner to me.  Same with below.

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor.h:240:
std::unique_ptr<cc::proto::CompositorMessage> pending_frame_update_;
Can we guarantee we're only sending one at a time?  Might be worth putting that
assumption here in a comment for now.

[Khushal, 2016-10-13 16:36:37]

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor.cc (right):

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor.cc:369: if
(!use_threaded_layer_tree_host_)
On 2016/10/13 15:18:41, David Trainor wrote:
> {} if the line wraps?  Would feel cleaner to me.  Same with below.

Done.

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
File blimp/client/core/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/2415633003/diff/40001/blimp/client/core/compo...
blimp/client/core/compositor/blimp_compositor.h:240:
std::unique_ptr<cc::proto::CompositorMessage> pending_frame_update_;
On 2016/10/13 15:18:41, David Trainor wrote:
> Can we guarantee we're only sending one at a time?  Might be worth putting
that
> assumption here in a comment for now.

At least for now yes. Might change when we start doing interest rect
manipulations but that's very far off.

[Khushal, 2016-10-20 02:00:42]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 02:01:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 04:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 04:00:34]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-10-26 02:42:17]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-10-26 02:42:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2415633003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-26 02:42:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:11:42]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-10-26 04:12:16]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:12:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:35:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-10-26 04:36:43]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 05:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 05:22:39]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Khushal, 2016-10-26 05:24:19]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-10-26 05:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 05:35:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-26 05:37:52]

Description was changed from

==========
blimp: Add mode to use the updated compositing path on the client.

Sets up the code to use a threaded LayerTreeHost on the BlimpCompositor
on the client. The compositor now creates a threaded
LayerTreeHostInProcess. The flow of updates is as follows:

1) The engine will send a frame update in the CompositorMessage.
2) On receiving the update, the client requests the LayerTreeHost to
schedule a main frame.
3) When the LayerTreeHost asks its client to update its state, the
frame update in the proto is deserialized using the
CompositorStateDeserializer.

BUG=648442
==========

to

==========
blimp: Add mode to use the updated compositing path on the client.

Sets up the code to use a threaded LayerTreeHost on the BlimpCompositor
on the client. The compositor now creates a threaded
LayerTreeHostInProcess. The flow of updates is as follows:

1) The engine will send a frame update in the CompositorMessage.
2) On receiving the update, the client requests the LayerTreeHost to
schedule a main frame.
3) When the LayerTreeHost asks its client to update its state, the
frame update in the proto is deserialized using the
CompositorStateDeserializer.

BUG=648442

Committed: https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4
Cr-Commit-Position: refs/heads/master@{#427597}
==========

[commit-bot: I haz the power, 2016-10-26 05:37:53]

Patchset 5 (id:??) landed as
https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4
Cr-Commit-Position: refs/heads/master@{#427597}