[wasm] Clean up wasm module implementation

[wasm] Clean up wasm module implementation

By defining functions with namespace prefix, the compiler checks that
they were previously declared, and checks that the signature matches.
I stumbled across this several times when changing the interface of a
function in the header.
With this change you get a compile error right away instead of a linker
error in the very end.

This change also revealed two functions which could be placed in an
anonymous namespace, saving 5.5kB program size in Debug build, 2.3kB in
Optdebug and 0.3kB in Release. It's also opening more options for
compiler optimizations, as the functions now have internal linkage.

R=titzer@chromium.org

Committed: https://crrev.com/8d19005336d9e4828ec3e24798ce094d3388848a
Cr-Commit-Position: refs/heads/master@{#40233}

[Clemens Hammacher, 2016-10-12 15:05:14]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 15:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-12 15:21:08]

I tripped over this a few times, so I thought I would try to fix it. In the end,
it's probably a matter of code style.

[titzer, 2016-10-12 15:28:41]

lgtm

We currently have a lot of top-level functions, and we might want to think about
(re)organizing them into classes.

[commit-bot: I haz the power, 2016-10-12 15:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:31:55]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-10-12 15:38:15]

On 2016/10/12 15:28:41, titzer wrote:
> lgtm
> 
> We currently have a lot of top-level functions, and we might want to think
about
> (re)organizing them into classes.

Yes, a class for WasmObject (the dynamic instance) is definitely needed. I'll
land this CL for now anyway.

[Clemens Hammacher, 2016-10-12 15:38:20]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:38:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:41:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-12 15:41:22]

Description was changed from

==========
[wasm] Clean up wasm module implementation

By defining functions with namespace prefix, the compiler checks that
they were previously declared, and checks that the signature matches.
I stumbled across this several times when changing the interface of a
function in the header.
With this change you get a compile error right away instead of a linker
error in the very end.

This change also revealed two functions which could be placed in an
anonymous namespace, saving 5.5kB program size in Debug build, 2.3kB in
Optdebug and 0.3kB in Release. It's also opening more options for
compiler optimizations, as the functions now have internal linkage.

R=titzer@chromium.org
==========

to

==========
[wasm] Clean up wasm module implementation

By defining functions with namespace prefix, the compiler checks that
they were previously declared, and checks that the signature matches.
I stumbled across this several times when changing the interface of a
function in the header.
With this change you get a compile error right away instead of a linker
error in the very end.

This change also revealed two functions which could be placed in an
anonymous namespace, saving 5.5kB program size in Debug build, 2.3kB in
Optdebug and 0.3kB in Release. It's also opening more options for
compiler optimizations, as the functions now have internal linkage.

R=titzer@chromium.org

Committed: https://crrev.com/8d19005336d9e4828ec3e24798ce094d3388848a
Cr-Commit-Position: refs/heads/master@{#40233}
==========

[commit-bot: I haz the power, 2016-10-12 15:41:23]

Patchset 1 (id:??) landed as
https://crrev.com/8d19005336d9e4828ec3e24798ce094d3388848a
Cr-Commit-Position: refs/heads/master@{#40233}