Revert IDL compiler build flow to Perl, rename 'deprecated'

Revert IDL compiler build flow to Perl, rename 'deprecated'

To prevent IDL compiler rewrite from slowing down other developers,
we're moving the build flow 100% back to Perl.
We'll then incrementally review and land the Python rewrite, and
when it's 100% done in tree, we'll switch it over in one go.
This way other developers don't need to be concerned with the rewrite.
(I'll handle syncing Perl changes to the Python rewrite.)

This also removes the scary "deprecated" prefix from the Perl, so
people are not discouraged from hacking on it.

Also makes the Python bindings tests optional (not used by default),
so still usable by run-time flag, but not run in presubmit scripts.

BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157996

[Nils Barth (inactive), 2013-09-17 11:00:56]

Hi haraken,
Here's a CL moving build flow back to Perl, together with other cleanup, as
discussed.
Look ok?

[haraken, 2013-09-17 13:25:53]

Looks OK. Thanks for doing this.

It's a bit sad that we cannot upstream the new compiler incrementally. However,
given that it will take more months to complete, reverting back to the old
compiler for now would be a good thing to do. Once we complete the new IDL
compiler, we can switch to the new one in one go.

Would you move all Python files under bindings/scripts/untested, to make it
clear that the Python compiler is not yet ready?

Also, you might want to announce this change to blink-dev after landing (or I
can announce it).

[Nils Barth (inactive), 2013-09-18 00:57:06]

On 2013/09/17 13:25:53, haraken wrote:
> It's a bit sad that we cannot upstream the new compiler incrementally.

Yeah, it's unfortunate that we can't turn it on incrementally, though we can
review and land it incrementally.
Still, the work in refactoring derived_sources.gyp so we could have either Perl
or Python build made the build rather clearer, so it's made it easier for e.g.
Kihong's CL on testing dependencies.

> Would you move all Python files under bindings/scripts/untested, to make it
> clear that the Python compiler is not yet ready?

Should I document this somewhere in the code?
(I.e., "This is in development, once it's finished we'll switch over, see
crbug.com/xxx")

I could add a README.txt, or put a note in idl_compiler.py or
code_generator_v8.py...

Also, the name "untested" is a bit misleading -- it's really incomplete (we
*know* it doesn't all work).
scripts/wip? scripts/dev?

> Also, you might want to announce this change to blink-dev after landing (or I
> can announce it).

Got it. How about I draft something and have you check it before I send it?

[haraken, 2013-09-18 03:01:21]

On 2013/09/18 00:57:06, Nils Barth wrote:
> > Would you move all Python files under bindings/scripts/untested, to make it
> > clear that the Python compiler is not yet ready?
> 
> Should I document this somewhere in the code?
> (I.e., "This is in development, once it's finished we'll switch over, see
> crbug.com/xxx")
> 
> I could add a README.txt, or put a note in idl_compiler.py or
> code_generator_v8.py...

- We don't want to add a new convention to Blink (e.g., README.txt).
- What we want is just to make it clear that the new compiler is under
development.

So, I'd suggest putting the compiler into scripts/xxx and adding comments to
each file.

Regarding xxx, I'd prefer "wip" or "unstable". Remember that ideally we don't
want to upstream the broken compiler to the Blink trunk until we complete it.
We're upstreaming the compiler just to make your development easier. So, at the
very least, we want to name the directory to make it clear that the new compiler
is not stable.

[Nils Barth (inactive), 2013-09-18 03:06:06]

On 2013/09/18 03:01:21, haraken wrote:
> - We don't want to add a new convention to Blink (e.g., README.txt).
> - What we want is just to make it clear that the new compiler is under
> development.
> 
> So, I'd suggest putting the compiler into scripts/xxx and adding comments to
> each file.
> 
> Regarding xxx, I'd prefer "wip" or "unstable". Remember that ideally we don't
> want to upstream the broken compiler to the Blink trunk until we complete it.
> We're upstreaming the compiler just to make your development easier. So, at
the
> very least, we want to name the directory to make it clear that the new
compiler
> is not stable.

Got it -- I'll put it in "unstable" and put a comment in each module's
docstring!

[Nils Barth (inactive), 2013-09-18 09:41:53]

Moved Python compiler to "unstable" and put a comment in the docstrings.
How does it look?

[haraken, 2013-09-18 09:45:35]

LGTM

https://codereview.chromium.org/24156003/diff/8001/Source/bindings/scripts/un...
File Source/bindings/scripts/unstable/code_generator_v8.py (right):

https://codereview.chromium.org/24156003/diff/8001/Source/bindings/scripts/un...
Source/bindings/scripts/unstable/code_generator_v8.py:31: UNSTABLE: Not
currently used in build.

UNSTABLE => FIXME ?

[commit-bot: I haz the power, 2013-09-18 09:53:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/24156003/14001

[Nils Barth (inactive), 2013-09-18 09:53:30]

https://codereview.chromium.org/24156003/diff/8001/Source/bindings/scripts/un...
File Source/bindings/scripts/unstable/code_generator_v8.py (right):

https://codereview.chromium.org/24156003/diff/8001/Source/bindings/scripts/un...
Source/bindings/scripts/unstable/code_generator_v8.py:31: UNSTABLE: Not
currently used in build.
On 2013/09/18 09:45:36, haraken wrote:
> UNSTABLE => FIXME ?

Done!

[commit-bot: I haz the power, 2013-09-18 11:58:14]

Failed to apply patch for Source/bindings/scripts/unstable/blink_idl_parser.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/bindings/scripts/unstable/blink_idl_parser.py
  Copied Source/bindings/scripts/blink_idl_parser.py ->
Source/bindings/scripts/unstable/blink_idl_parser.py
  patching file Source/bindings/scripts/unstable/blink_idl_parser.py
  Hunk #1 FAILED at 56.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/scripts/unstable/blink_idl_parser.py.rej

Patch:   NR 
Source/bindings/scripts/blink_idl_parser.py->Source/bindings/scripts/unstable/blink_idl_parser.py
Index: Source/bindings/scripts/unstable/blink_idl_parser.py
diff --git a/Source/bindings/scripts/blink_idl_parser.py
b/Source/bindings/scripts/unstable/blink_idl_parser.py
similarity index 99%
rename from Source/bindings/scripts/blink_idl_parser.py
rename to Source/bindings/scripts/unstable/blink_idl_parser.py
index
121d218bf5139c35bcacedf18db22b250473e689..d34955eef75d73799d86e85d74d1399268389df6
100644
--- a/Source/bindings/scripts/blink_idl_parser.py
+++ b/Source/bindings/scripts/unstable/blink_idl_parser.py
@@ -56,12 +56,12 @@ import sys
 
 # PLY is in Chromium src/third_party/ply
 module_path, module_name = os.path.split(__file__)
-third_party = os.path.join(module_path, os.pardir, os.pardir, os.pardir,
os.pardir)
+third_party = os.path.join(module_path, os.pardir, os.pardir, os.pardir,
os.pardir, os.pardir)
 sys.path.append(third_party)
 from ply import yacc
 
 # Base parser is in Chromium src/tools/idl_parser
-tools_dir = os.path.join(module_path, os.pardir, os.pardir, os.pardir,
os.pardir, os.pardir, 'tools')
+tools_dir = os.path.join(module_path, os.pardir, os.pardir, os.pardir,
os.pardir, os.pardir, os.pardir, 'tools')
 sys.path.append(tools_dir)
 from idl_parser.idl_parser import IDLParser, ListFromConcat
 from idl_parser.idl_parser import ParseFile as parse_file

[commit-bot: I haz the power, 2013-09-19 01:40:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/24156003/26001

[commit-bot: I haz the power, 2013-09-19 02:49:52]

Change committed as 157996