Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2415583002: PPC/s390: [stubs] Refactor the CallICStub to pass the number of arguments. (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Refactor the CallICStub to pass the number of arguments. Port c15c58274f04eef9d62245f33a836cd8287b9c53 Original commit message: This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/c6f8955e46c8c87dc262e61cf42a5387594ab0a8 Cr-Commit-Position: refs/heads/master@{#40228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-12 14:09:31 UTC) #1
john.yan
lgtm
4 years, 2 months ago (2016-10-12 14:12:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415583002/1
4 years, 2 months ago (2016-10-12 14:12:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 14:38:27 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 14:38:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6f8955e46c8c87dc262e61cf42a5387594ab0a8
Cr-Commit-Position: refs/heads/master@{#40228}

Powered by Google App Engine
This is Rietveld 408576698