Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json

Issue 2415543004: Download the hermetic xcode toolchain on all bots that target mac. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
diff --git a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json b/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
index 9cdbe80baa67bff1ff18b75e28a02c7572c13450..04603f64be98d62fdaceaf74be8124235c5c1efa 100644
--- a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
+++ b/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
@@ -144,6 +144,7 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
+ "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"GYP_CHROMIUM_NO_ACTION": "1",
"GYP_DEFINES": "clang=1 dcheck_always_on=1 fastbuild=1 gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",
@@ -182,6 +183,7 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
+ "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "generate_build_files",
@@ -243,6 +245,7 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
+ "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "generate_build_files with gn (fyi)"
@@ -280,6 +283,7 @@
"/path/to/tmp/json"
],
"env": {
+ "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "clang_revision",
@@ -329,6 +333,7 @@
"--"
],
"env": {
+ "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "compile",

Powered by Google App Engine
This is Rietveld 408576698