scripts/slave/recipe_modules/chromium_tests/chromium_mac.py - Issue 2415543004: Download the hermetic xcode toolchain on all bots that target mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_mac.py

Issue 2415543004: Download the hermetic xcode toolchain on all bots that target mac. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/chromium_mac.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py b/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py

index 7d079bba8896d22a3c5354914c9cc5bce0dd6021..80f5ed33af1e9405c8571ec0321f91e622abed3d 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py

@@ -20,7 +20,6 @@ SPEC = {

'chrome_with_codecs',

'mb',

'ninja_confirm_noop',

- 'force_mac_toolchain',

'gclient_config': 'chromium',

'chromium_config_kwargs': {

@@ -40,7 +39,7 @@ SPEC = {

'Mac10.9 Tests': {

'chromium_config': 'chromium',

- 'chromium_apply_config': ['ninja_confirm_noop', 'force_mac_toolchain'],

+ 'chromium_apply_config': ['ninja_confirm_noop'],

'gclient_config': 'chromium',

'chromium_config_kwargs': {

'BUILD_CONFIG': 'Release',

@@ -58,7 +57,7 @@ SPEC = {

'Mac10.10 Tests': {

'chromium_config': 'chromium',

- 'chromium_apply_config': ['ninja_confirm_noop', 'force_mac_toolchain'],

+ 'chromium_apply_config': ['ninja_confirm_noop'],

'gclient_config': 'chromium',

'chromium_config_kwargs': {

'BUILD_CONFIG': 'Release',

@@ -75,7 +74,7 @@ SPEC = {

'Mac10.11 Tests': {

'chromium_config': 'chromium',

- 'chromium_apply_config': ['ninja_confirm_noop', 'force_mac_toolchain'],

+ 'chromium_apply_config': ['ninja_confirm_noop'],

'gclient_config': 'chromium',

'chromium_config_kwargs': {

'BUILD_CONFIG': 'Release',

@@ -92,7 +91,6 @@ SPEC = {

'chromium_apply_config': [

'mb',

'ninja_confirm_noop',

- 'force_mac_toolchain'

'gclient_config': 'chromium',

'chromium_config_kwargs': {

@@ -112,7 +110,7 @@ SPEC = {

'Mac10.9 Tests (dbg)': {

'chromium_config': 'chromium',

- 'chromium_apply_config': ['ninja_confirm_noop', 'force_mac_toolchain'],

+ 'chromium_apply_config': ['ninja_confirm_noop'],

'gclient_config': 'chromium',

'chromium_config_kwargs': {

'BUILD_CONFIG': 'Debug',